Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.1] Fix TinyMCE media button, insert link bug #43374

Merged
merged 4 commits into from
May 11, 2024
Merged

[5.1] Fix TinyMCE media button, insert link bug #43374

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6339fe1
Fix TinyMCE media button, insert link bug
Fedik Apr 26, 2024
99fb049
Merge branch '5.1-dev' into fix-43365
Quy May 8, 2024
737309e
Merge branch '5.1-dev' into fix-43365
LadySolveig May 11, 2024
34fddee
Merge branch '5.1-dev' into fix-43365
LadySolveig May 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix TinyMCE media button, insert link bug
  • Loading branch information
@Fedik
Fedik committed Apr 26, 2024
commit 6339fe1313b4453df5a4d95b0e05b548c8486098
4 changes: 2 additions & 2 deletions build/media_source/system/js/fields/joomla-media-select.w-c.es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,8 @@ const insertAsOther = (media, editor, fieldClass, type) => {
<source src="${Joomla.selectedMediaFile.url}" type="${Joomla.selectedMediaFile.fileType}">
</video>`;
}
} else if (Joomla.editors.instances[editor].getSelection() !== '') {
outputText = `<a download href="${Joomla.selectedMediaFile.url}">${Joomla.editors.instances[editor].getSelection()}</a>`;
} else if (editorInst.getSelection() !== '') {
outputText = `<a download href="${Joomla.selectedMediaFile.url}">${editorInst.getSelection()}</a>`;
} else {
const name = /([\w-]+)\./.exec(Joomla.selectedMediaFile.url);
outputText = `<a download href="${Joomla.selectedMediaFile.url}">${Joomla.Text._('JFIELD_MEDIA_DOWNLOAD_FILE').replace('{file}', name[1])}</a>`;
Expand Down