Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly state our argument separator when calling http_build_query(). #43452

Open
wants to merge 1 commit into
base: 4.4-dev
Choose a base branch
from
Open

Explicitly state our argument separator when calling http_build_query(). #43452

wants to merge 1 commit into from

Commits on May 9, 2024

  1. Explicitly state our argument separator when calling http_build_query(). 

    When the PHP arg_separator.input configuration option is not set to &
(e.g. if it's set to &) then this will result in malformed encoded
strings. Sometimes this is generally OK, but when using
http_build_query() to format POST data (e.g. in the Http/Transport
classes) this can result in malformed POSTs and failing APIs

This is easily seen in e.g. reCaptcha verification requests.
    @coling
    coling committed May 9, 2024
    Configuration menu
    Copy the full SHA
    5f4fbcb View commit details
    Browse the repository at this point in the history