-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Add Files folder to Media component and to "FileSystem local" adapter #43532
base: 5.2-dev
Are you sure you want to change the base?
Conversation
@Fedik please add the
|
FWIW I would prefer the folder to be named |
Added. I think |
Currently there still a limitation (pretty huge), the custom field for Media does not allow to select anything else than folders under joomla-cms/plugins/fields/media/params/media.xml Lines 6 to 9 in 5e3d848
I think it will need another field to allow to pick folders from Media manager adapters, but that something for another PR. |
You're right, there's a
|
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
One more thing, could you add an
Since this is a new folder we can restrict it to ONLY static files. (the same should be applied to images and media folders but that's irrelevant to this PR) |
Actualy, that "todo" can be already trashed, since we have
Hmhm, I can, but this can affect people who already have /files folder, and use it on its own purpuse. |
It seems the system tests need to be adapted, too. Currently they fail at file
|
Yeap, I will look on it later |
I really like it, just the name is for me too generic. I would rather go with documents, if you name them files, then should the images also be moved there. Or you can go with /files/images and /files/documents. But having a generic files in root which directly contains everything except images is for me not logical. |
I will keep it generic. |
I found a bug in media manager API, it always return path without adapter
And when you doing API call with non default adapter, |
I am a bit confused about the need for this PR. If I create a folder myself in the root of the web space then I can already achieve everything that this PR does - what am i missing? |
You need to create the folder by yourself. That what you missing 😉 |
Then I dont see the point in adding this |
I do not know, man. I do not know what to say. Look, we have allowed uploads There still limitation that need to address, like hardcoded |
It was and we removed it |
From a Joomla extension developer view, this change is much needed. It is helpful not only for the core com_media. Thank you for adding it. |
Pull Request for Issue # .
Summary of Changes
Trying to add
/files
folder, addittionaly to existing/images
folder.It is not very logical to have PDF (and other) documents under
/images
.The changes affects new installations. Existing installations should continue to work as usual.
Testing Instructions
Check that Media manager works.
Upload images/files in Media manager view, upload images using Media field in Article editing, etc.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select: