Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2][Events] Use event classes for Extension plugins #43617

Merged
merged 8 commits into from
Aug 28, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
extension NamespaceMap
  • Loading branch information
Fedik committed Jun 4, 2024
commit 23c5ffd83c3cac6ecbc322b9f27666ac2eac8804
45 changes: 30 additions & 15 deletions plugins/extension/namespacemap/src/Extension/NamespaceMap.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,12 @@

namespace Joomla\Plugin\Extension\NamespaceMap\Extension;

use Joomla\CMS\Installer\Installer;
use Joomla\CMS\Event\Extension\AfterInstallEvent;
use Joomla\CMS\Event\Extension\AfterUninstallEvent;
use Joomla\CMS\Event\Extension\AfterUpdateEvent;
use Joomla\CMS\Plugin\CMSPlugin;
use Joomla\Event\DispatcherInterface;
use Joomla\Event\SubscriberInterface;

// phpcs:disable PSR1.Files.SideEffects
\defined('_JEXEC') or die;
Expand All @@ -23,7 +26,7 @@
*
* @since 4.0.0
*/
final class NamespaceMap extends CMSPlugin
final class NamespaceMap extends CMSPlugin implements SubscriberInterface
{
/**
* The namespace map file creator
Expand All @@ -50,20 +53,35 @@ public function __construct(DispatcherInterface $dispatcher, \JNamespacePsr4Map
parent::__construct($dispatcher, $config);
}

/**
* Returns an array of events this subscriber will listen to.
*
* @return array
*
* @since __DEPLOY_VERSION__
*/
public static function getSubscribedEvents(): array
{
return [
'onExtensionAfterInstall' => 'onExtensionAfterInstall',
'onExtensionAfterUpdate' => 'onExtensionAfterUpdate',
'onExtensionAfterUninstall' => 'onExtensionAfterUninstall',
];
}

/**
* Update / Create map on extension install
*
* @param Installer $installer Installer instance
* @param integer $eid Extension id
* @param AfterInstallEvent $event Event instance.
*
* @return void
*
* @since 4.0.0
*/
public function onExtensionAfterInstall($installer, $eid)
public function onExtensionAfterInstall(AfterInstallEvent $event): void
{
// Check that we have a valid extension
if ($eid) {
if ($event->getEid()) {
// Update / Create new map
$this->fileCreator->create();
}
Expand All @@ -72,18 +90,16 @@ public function onExtensionAfterInstall($installer, $eid)
/**
* Update / Create map on extension uninstall
*
* @param Installer $installer Installer instance
* @param integer $eid Extension id
* @param boolean $removed Installation result
* @param AfterUninstallEvent $event Event instance.
*
* @return void
*
* @since 4.0.0
*/
public function onExtensionAfterUninstall($installer, $eid, $removed)
public function onExtensionAfterUninstall(AfterUninstallEvent $event): void
{
// Check that we have a valid extension and that it has been removed
if ($eid && $removed) {
if ($event->getEid() && $event->getRemoved()) {
// Update / Create new map
$this->fileCreator->create();
}
Expand All @@ -92,17 +108,16 @@ public function onExtensionAfterUninstall($installer, $eid, $removed)
/**
* Update map on extension update
*
* @param Installer $installer Installer instance
* @param integer $eid Extension id
* @param AfterUpdateEvent $event Event instance.
*
* @return void
*
* @since 4.0.0
*/
public function onExtensionAfterUpdate($installer, $eid)
public function onExtensionAfterUpdate(AfterUpdateEvent $event): void
{
// Check that we have a valid extension
if ($eid) {
if ($event->getEid()) {
// Update / Create new map
$this->fileCreator->create();
}
Expand Down