Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x][RFC] CMSPlugin: Subscriber Registration Checker Interface #43657

Open
wants to merge 5 commits into
base: 5.2-dev
Choose a base branch
from
Open

[5.x][RFC] CMSPlugin: Subscriber Registration Checker Interface #43657

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
27a1218
RegisterListenersChecker
Fedik Jun 14, 2024
98f3ecd
RegisterListenersChecker
Fedik Jun 14, 2024
f83ff97
SubscriberRegistrationCheckerInterface
Fedik Jun 14, 2024
b9a2f23
SubscriberRegistrationCheckerInterface
Fedik Jun 14, 2024
6caec26
SubscriberRegistrationCheckerInterface
Fedik Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
SubscriberRegistrationCheckerInterface
  • Loading branch information
@Fedik
Fedik committed Jun 14, 2024
commit b9a2f237f2383295463617fad6ff66baa6cf92da
17 changes: 16 additions & 1 deletion plugins/system/debug/src/Extension/Debug.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
use Joomla\CMS\Application\CMSApplicationInterface;
use Joomla\CMS\Document\HtmlDocument;
use Joomla\CMS\Event\Plugin\AjaxEvent;
use Joomla\CMS\Event\SubscriberRegistrationCheckerInterface;
use Joomla\CMS\Log\Log;
use Joomla\CMS\Log\LogEntry;
use Joomla\CMS\Log\Logger\InMemoryLogger;
Expand Down Expand Up @@ -53,7 +54,7 @@
*
* @since 1.5
*/
final class Debug extends CMSPlugin implements SubscriberInterface
final class Debug extends CMSPlugin implements SubscriberInterface, SubscriberRegistrationCheckerInterface
{
use DatabaseAwareTrait;

Expand Down Expand Up @@ -223,6 +224,20 @@ public function __construct(DispatcherInterface $dispatcher, array $config, CMSA
}
}

/**
* Check whether the Subscriber should be registered.
*
* @return bool
*
* @since __DEPLOY_VERSION__
*/
public function shouldRegisterListeners(): bool
{
$app = $this->getApplication();

return $app->get('debug') || $app->get('debug_lang');
}

/**
* Add an assets for debugger.
*
Expand Down