Fix content-type
header to application/json
#43689
Open
+2
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #43641.
Summary of Changes
JsonDocument
in Joomla 4.4.5 wrongly setstext/plain
to all browsers (tested onEdge
,Firefox
andChrome
). Browsers do not usually sendapplication/json
, instead they send*/*
with some lower priority.Note: Joomla 5 already fixed this, so this change needs to be merged to Joomla 4 (maybe Joomla 4.4.6?).
Testing Instructions
Ping and API endpoint that
extends JsonDocument
. In my case I am returning a normaljson
response instead of ajson:api
.Actual result BEFORE applying this Pull Request
Ping an API endpoint like
localhost/api/index.php/v1/example
:Content-Type: text/plain; charset=utf-8
Expected result AFTER applying this Pull Request
Ping an API endpoint like
localhost/api/index.php/v1/example
:Content-Type: application/json; charset=utf-8
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed