Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer custom field to be numerical input instead of a drop-down #43697

Open
wants to merge 4 commits into
base: 5.2-dev
Choose a base branch
from

Conversation

sakiss
Copy link
Contributor

@sakiss sakiss commented Jun 24, 2024

Pull Request for Issue #42579

Summary of Changes

So far the Integer custom field is a drop-down list.
Though it is crashing the browser when the list becomes too long. Moreover it is really hard to use, after a certain length.

With the PR the Integer custom field is an input of type number. Though, it still follows the min, max and step settings, that existed.

Testing Instructions

Try setting up a custom field of type "Integer" for an article.
Within the article you will see an input, instead of a drop-down,

Actual result BEFORE applying this Pull Request

Drop-down list.

Expected result AFTER applying this Pull Request

Input of type number

Link to documentations

DKN

@sakiss sakiss changed the title Integer custom field to be numerical Integer custom field to be numerical input instead of a drop-down Jun 24, 2024
@sakiss sakiss changed the base branch from 4.4-dev to 5.2-dev June 24, 2024 13:41
@Fedik
Copy link
Member

Fedik commented Jun 24, 2024

Thanks for the PR.
Before you continue. We should not change existing integer field. And instead of it, need to create a new Number custom field, which will use NumberField class.

@Fedik Fedik added Feature and removed PR-4.4-dev labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants