[4] fix for cypress 1.1.0 hack #43726
Conversation
| @@ -88,8 +88,9 @@ protected function prepareDocument() | |||
| $category = $this->category->getParent(); | |||
|
|
|||
| while ( | |||
| (!isset($menu->query['option']) || $menu->query['option'] !== 'com_newsfeeds' || $menu->query['view'] === 'newsfeed' | |||
| || $id != $category->id) && $category->id > 1 | |||
| isset($category->id) && $category->id > 1 | |||
There was a problem hiding this comment.
What scenario are we fixing here? We've validated the menu item against the category supplied above. We can check the category coming back isn't null as a sanity check I guess (although I don't understand why this wouldn't need the same fix in 5.0 - but supposedly this isn't an issue there) - but I don't see why we need to check the id is greater than 1. Like I say how do we end up in this scenario?
There was a problem hiding this comment.
backporting joomla-cypress 1.1.0 to 4.x avoiding hacks
There was a problem hiding this comment.
Fair enough :) I didn't realise all the fixes were backports from the 5.x branch. I guess it will do then. I don't like it - but we shouldn't merge more back into the 5.x branch
|
Can you explain the logic behind the HtmlView check? I completely understand the datetime one in the tests folder - but not the other one (yes I've seen the test failures but that doesn't explain to me the fix being made here) |
|
didn't digged in too much, just an attempt to equalize, what it is running on 5.x |
|
moved to muhme#6 |
related to #43722