Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Field ModalSelect: make sure token in the URLs #43745

Merged
merged 5 commits into from
Jul 26, 2024

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Jul 6, 2024

Pull Request for Issue # .

Summary of Changes

Fix for the ModalSelect field, always add the token to the urls.

Testing Instructions

Run npm install

Add ModalSelect field in to Custom HTML module XML:

<field
  type="ModalSelect"
  name="article"
  label="Article"

  select="true"
  titleSelect="Selecting the Article"
  urlSelect="index.php?option=com_content&amp;view=articles&amp;layout=modal&amp;tmpl=component"
  clear="true"
/>

Then open Custom HTML module editing on the site (not administrator). And try to select the article, using "select" button.

Actual result BEFORE applying this Pull Request

An error, kind of "wrong token"

Expected result AFTER applying this Pull Request

All works, you should be able to select the article

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Jul 6, 2024
@Fedik Fedik added the bug label Jul 6, 2024
@Quy
Copy link
Contributor

Quy commented Jul 9, 2024

I have tested this item ✅ successfully on 9b02403


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43745.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 9b02403


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43745.

@Quy
Copy link
Contributor

Quy commented Jul 10, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43745.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 10, 2024
@robbiejackson
Copy link

I have tested this item ✅ successfully on 1b734cd

Test form now works well on the site front-end.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43745.

@LadySolveig LadySolveig added this to the Joomla! 5.1.3 milestone Jul 26, 2024
@LadySolveig LadySolveig merged commit 37ee470 into joomla:5.1-dev Jul 26, 2024
2 of 3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 26, 2024
@LadySolveig
Copy link
Contributor

Thank you @Fedik and also for testing @Quy @viocassel @robbiejackson !

@Fedik Fedik deleted the content-select-token2 branch July 26, 2024 17:23
dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Aug 11, 2024
dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants