Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] [cli] TasksListCommand fix deprecation when execution = manual #43750

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Jul 7, 2024

Pull Request for Issue #43665 .

Summary of Changes

cover only the cli part
fix deprecation

Testing Instructions

Create a scheduled task with Execution Rule on Manual
execute the command line scheduler:list

Actual result BEFORE applying this Pull Request

fix deprecation

Expected result AFTER applying this Pull Request

no deprecation

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brbrbr
Copy link

brbrbr commented Jul 7, 2024

Works

@richard67
Copy link
Member

Works

@brbrbr If you have tested this PR, please mark your result in the issue tracker here https://issues.joomla.org/tracker/joomla-cms/43750 by using the blue "Test this" button at the top left corner, then selecting the test result and finally submit. This is needed so that the test result is properly counted. It needs 2 successful tests for each PR to get accepted. You can help with that by marking your test result. Thanks in advance.

@brbrbr
Copy link

brbrbr commented Jul 7, 2024

I have tested this item ✅ successfully on 76f91e9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43750.

@richard67
Copy link
Member

@brbrbr Thanks for testing.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 76f91e9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43750.

@richard67
Copy link
Member

@viocassel Thanks for testing.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43750.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 7, 2024
@richard67 richard67 added the bug label Jul 7, 2024
@bembelimen bembelimen changed the title [cli] TasksListCommand fix deprecation when execution = manual [4.4] [cli] TasksListCommand fix deprecation when execution = manual Jul 7, 2024
@MacJoom MacJoom self-assigned this Jul 10, 2024
@MacJoom MacJoom added this to the Joomla! 4.4.7 milestone Jul 11, 2024
@MacJoom MacJoom merged commit 7133483 into joomla:4.4-dev Jul 11, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 11, 2024
@MacJoom
Copy link
Contributor

MacJoom commented Jul 11, 2024

Thank you!

@alikon alikon deleted the patch-21 branch July 12, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants