Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Use created_by 0 if created_by is empty #43752

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Jul 7, 2024

Pull Request for Issue #43674 .

Summary of Changes

Make sure that created_by = 0

Testing Instructions

see #43674, change the Author of an article to "no user"

Actual result BEFORE applying this Pull Request

Save failed with the following error: Incorrect integer value: '' for column joomla_51.xw6tv_content.created_by at row 1

Expected result AFTER applying this Pull Request

Article is saved and created_by is set to 0.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 238b1b8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43752.

@SimVT
Copy link

SimVT commented Jul 7, 2024

I tested this successfully on both a new and existing 5.1.1 installation.

@richard67
Copy link
Member

@SimVT If you have tested this PR, please mark your result in the issue tracker here https://issues.joomla.org/tracker/joomla-cms/43752 by using the blue "Test this" button at the top left corner, then selecting the test result and finally submit. This is needed so that the test result is properly counted. It needs 2 successful tests for each PR to get accepted. You can help with that by marking your test result. Thanks in advance.

@SimVT
Copy link

SimVT commented Jul 7, 2024

I have tested this item ✅ successfully on 238b1b8

I tested this successfully on both a new and existing 5.1.1 installation.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43752.

@SimVT
Copy link

SimVT commented Jul 7, 2024

Thank you Richard67 and my apologies for not knowing the process.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43752.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43752.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 7, 2024
@LadySolveig LadySolveig merged commit 9446241 into joomla:5.1-dev Jul 8, 2024
2 of 3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 8, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.2 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants