-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amend Joomla version check URL to allow for non-English wiki pages. #4380
Conversation
Amend Joomla version check URL to allow for non-English wiki pages. This might not work initially because there are some changes that need to be done on the wiki too.
@chrisdavenport the result after the patch is:
|
hehe I should read your comment too. Sorry @chrisdavenport |
@zero-24 it should work now. All we are really testing for is /en appended to the url. 😄 or any language set as default in administaror. Thanks! |
@Hutchy68 @chrisdavenport it works now for english but is it possible to fallback to english if there is no for the current language? Example |
@zero-24 Possibly. I need to make some changes in the proxy for that to work. We're looking into it. |
thanks @chrisdavenport 👍 |
ATM, I do not get a lang prefix |
@infograf768 this only affect the version check atm |
I've merged this into Thanks! |
@mbabker this break atm (if nothing is changed at the proxy) all non english backends that use the Joomla Help Version check. |
Since it's on the development branch and the problem code is within our own infrastructure, this is OK for the moment. If we get to the beta stage and it's not fixed, we can look at reverting it out. |
ok. |
This should be working now. Please make sure that the version check still works in English. With a non-English language, if there is no wiki page for that language it should fall back to the English page. However, the language selection should be propagated so clicking on a link in the English page will still take you to the non-English page associated with that link, if it exists. |
thanks @chrisdavenport I have misunderstand you. I understand that you need to change something at the router in the CMS 👍 @test success using de-DE langauage pack 👍 (en-GB version is shown) @chrisdavenport have we a translation that can be tested? |
The Dutch (nl) page has been partially translated now, so you can test with that. |
thanks @chrisdavenport it works for me (using 3.3.4 via version.php as 3.3.6 is not translated yet) thanks @chrisdavenport and @Hutchy68 |
This might not work initially because there are some changes that need to be done on the wiki too.