Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend Joomla version check URL to allow for non-English wiki pages. #4380

Closed
wants to merge 1 commit into from
Closed

Amend Joomla version check URL to allow for non-English wiki pages. #4380

wants to merge 1 commit into from

Conversation

chrisdavenport
Copy link
Contributor

This might not work initially because there are some changes that need to be done on the wiki too.

Amend Joomla version check URL to allow for non-English wiki pages.  This might not work initially because there are some changes that need to be done on the wiki too.
@zero-24
Copy link
Contributor

zero-24 commented Sep 28, 2014

@chrisdavenport the result after the patch is:

http://docs.joomla.org/Help33:Joomla_Version_3_3_4/en that don't contain any content. The content is at http://docs.joomla.org/Help33:Joomla_Version_3_3_4 for me.

@zero-24
Copy link
Contributor

zero-24 commented Sep 28, 2014

hehe I should read your comment too. Sorry @chrisdavenport

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

@jissues-bot jissues-bot changed the title Amend Joomla version check URL to allow for non-English wiki pages. Amend Joomla version check URL to allow for non-English wiki pages. Sep 28, 2014
@Hutchy68
Copy link
Contributor

@zero-24 it should work now. All we are really testing for is /en appended to the url. 😄 or any language set as default in administaror. Thanks!

@zero-24
Copy link
Contributor

zero-24 commented Sep 28, 2014

@Hutchy68 @chrisdavenport it works now for english but is it possible to fallback to english if there is no for the current language?

Example http://docs.joomla.org/Help33:Joomla_Version_3_3_4/nl and http://docs.joomla.org/Help33:Joomla_Version_3_3_4/de

@chrisdavenport
Copy link
Contributor Author

@zero-24 Possibly. I need to make some changes in the proxy for that to work. We're looking into it.

@zero-24
Copy link
Contributor

zero-24 commented Sep 28, 2014

thanks @chrisdavenport 👍

@infograf768
Copy link
Member

ATM, I do not get a lang prefix
I get in the help modal
http://help.joomla.org/proxy/index.php?option=com_help&keyref=Help33:Site_System_Information
How to test that the prefix is added?
(Tested on 3.3.5-dev)

@zero-24
Copy link
Contributor

zero-24 commented Sep 29, 2014

@infograf768 this only affect the version check atm

@mbabker
Copy link
Contributor

mbabker commented Sep 29, 2014

I've merged this into 3.4-dev which will allow time for it to be tested and any backend structures updated prior to 3.4's release.

Thanks!

@mbabker mbabker closed this Sep 29, 2014
@zero-24
Copy link
Contributor

zero-24 commented Sep 29, 2014

@mbabker this break atm (if nothing is changed at the proxy) all non english backends that use the Joomla Help Version check.

@mbabker
Copy link
Contributor

mbabker commented Sep 29, 2014

Since it's on the development branch and the problem code is within our own infrastructure, this is OK for the moment. If we get to the beta stage and it's not fixed, we can look at reverting it out.

@zero-24
Copy link
Contributor

zero-24 commented Sep 29, 2014

ok.

@chrisdavenport
Copy link
Contributor Author

This should be working now. Please make sure that the version check still works in English. With a non-English language, if there is no wiki page for that language it should fall back to the English page. However, the language selection should be propagated so clicking on a link in the English page will still take you to the non-English page associated with that link, if it exists.

@zero-24
Copy link
Contributor

zero-24 commented Oct 2, 2014

thanks @chrisdavenport I have misunderstand you. I understand that you need to change something at the router in the CMS 👍

@test success using de-DE langauage pack 👍 (en-GB version is shown)

@chrisdavenport have we a translation that can be tested?

@chrisdavenport
Copy link
Contributor Author

The Dutch (nl) page has been partially translated now, so you can test with that.

@zero-24
Copy link
Contributor

zero-24 commented Oct 2, 2014

thanks @chrisdavenport

it works for me (using 3.3.4 via version.php as 3.3.6 is not translated yet)
nl-NL --> translated version available --> nl-NL version
de-DE --> no translated version available --> en-GB version
en-GB --> original --> en-GB version

thanks @chrisdavenport and @Hutchy68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants