Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to show all articles in the new mod_articles #44127

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

RickR2H
Copy link
Member

@RickR2H RickR2H commented Sep 23, 2024

Pull Request for Issue # .

Summary of Changes

With #43738 a new articles module is added. This new module mod_articles module has no option to show all articles. In the mod_articles_category for instance the "Articles to Display" can be set to 0 to show all articles. This PR add the option to set the "Articles to Display" to 0 to show all articles.

Testing Instructions

  • Set the "Articles to Display" to 0 to show all articles matching the settings.
  • New all articles are shown.

Actual result BEFORE applying this Pull Request.

The option "Articles to Display" cannot be set to 0 to show all articles.

Expected result AFTER applying this Pull Request

The option "Articles to Display" can be set to 0 to show all articles.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.2-dev labels Sep 23, 2024
@drmenzelit
Copy link
Contributor

I have tested this item ✅ successfully on 35c4a02


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44127.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 35c4a02


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44127.

@Quy
Copy link
Contributor

Quy commented Sep 23, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44127.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 23, 2024
@Hackwar Hackwar merged commit 5fdf00c into joomla:5.2-dev Sep 27, 2024
0 of 2 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 27, 2024
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Sep 27, 2024
@Hackwar
Copy link
Member

Hackwar commented Sep 27, 2024

Thanks for your contribution @RickR2H!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants