[5.3] Refactoring views to directly call models (installation & API) #44169
+28
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HLeithner
requested changes
Oct 1, 2024
| @@ -41,7 +41,7 @@ class JsonapiView extends BaseApiView | |||
| public function displayList(?array $items = null) | |||
| { | |||
| try { | |||
| $component = ComponentHelper::getComponent($this->get('component_name')); | |||
| $component = ComponentHelper::getComponent($this->component_name); | |||
There was a problem hiding this comment.
Can you please define the variable here as "public" or find a better solution?
because component_name is set by the controller with the LegacyPropertyManagementTrait::set method, which sets the property dynamic, as alternative a setComponentName() is needed which sets a protected/private property.
There was a problem hiding this comment.
So, after all this refactoring we still have some cases where set and get are used outside of the HtmlView.php files. To me that is another PR. Quite frankly, in this case I would rather revert this line and do that in another PR as well to not delay merging the rest. Would that be okay?
Quy
reviewed
Oct 1, 2024
| @@ -43,7 +43,11 @@ class DefaultView extends BaseHtmlView | |||
| */ | |||
| public function display($tpl = null) | |||
| { | |||
| $this->form = $this->get('Form'); | |||
| $model = $this->getModel(); | |||
There was a problem hiding this comment.
Suggested change
| $model = $this->getModel(); | |
| $model = $this->getModel(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR refactors the views to get the model object and then directly call the methods of the model instead of going through the
View::get()indirection. This refactors the views of the Joomla installation and of the web API.Testing Instructions
Everything should work the same.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed