Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JUX] Reducing language in admin mod_status #5

Closed
wants to merge 1 commit into from
Closed

[JUX] Reducing language in admin mod_status #5

wants to merge 1 commit into from

Conversation

kyleledbetter
Copy link
Contributor

[JUX] Reducing language in admin mod_status to take less horizontal space

Signed-off-by: Kyle Ledbetter

…pace

Signed-off-by: Kyle Ledbetter <kyle@kyleledbetter.com>
@elinw
Copy link
Contributor

elinw commented Oct 6, 2011

Kyle,

Can you please make a patch and post it in the joomlacode tracker since that is where the jbs looks for patches to test. Currently all commits are to be done via that route not by pull requests (though we all hope that is coming soon).

Thanks.

Elin

@eddieajau
Copy link
Contributor

Do you know who's making the call on how to process direct pull requests? I understand the JBS workflow needs to be taken into account, but from the contributor side of things, it's sooo much easier to handle.

@elinw
Copy link
Contributor

elinw commented Oct 7, 2011

Speak with Mark.

@infograf768
Copy link
Member

Please post on joomlacode tracker. Closing request.

@infograf768 infograf768 closed this Oct 9, 2011
@kyleledbetter
Copy link
Contributor Author

Hey all
Dang I'm so sorry, I wasn't getting my Github message notifications. From my understanding Github is now the main repo. Are we still required to go thru the joomlacode tracker?

@realityking
Copy link
Contributor

Yes, for now the JBS keeps working with patches (svn style patch mind you). Only change is that the gibhup repro is now the point of truth.

To my knowledge we can use pull requests for feature patches, we're just not supposed to use them for issue stuff.

@elkuku
Copy link
Contributor

elkuku commented Dec 6, 2011

One question..
Could we make a branch and submit the resulting diff link to the tracker ? this would ease the process (I think)..
I did this for tracker #27287 and it seems to work (committers satisfied), even with a git style patch ;)

@realityking
Copy link
Contributor

I guess most of the time that should be fine. I usually just do a git diff --no-prefix to be save. Isn't really any slower either ;)

@elkuku
Copy link
Contributor

elkuku commented Dec 6, 2011

What I mean is the diff link to the diff that is auto generated by GitHub.
e.g.: https://github.com/elkuku/joomla-cms/compare/com_users-login-fix.diff
which comes from: https://github.com/elkuku/joomla-cms/compare/com_users-login-fix
This would not include any history and such, but could be an interim solution until the committers feel comfortable with merging pull request (hopefully soonish)

@realityking
Copy link
Contributor

Ah sorry misunderstood you. Well just try how well it works ;)

As far as I understand it the problem isn't really merging pull requests, it's testing them. And that is kinda painful, especially when you're not used to remotes and stuff.

@elkuku
Copy link
Contributor

elkuku commented Dec 7, 2011

Testing patches ?
Well, this project deserves more attention (IMHO) https://github.com/ianmacl/patchtester

@infograf768
Copy link
Member

The point IMHO is not only testing a patch.
It is proposing modifications including important ones to be tested
for the same tracker/feature.
Proposals in github (comments incode. etc.) are just not fitting our needs.

NOTE: Concerning applying git-made .diff files using eclipse to an
SVN check-out, one has to simply set
"Ignore leading path name segements"
to 1

JM

Testing patches ?
Well, this project deserves more attention (IMHO)
https://github.com/ianmacl/patchtester


Reply to this email directly or view it on GitHub:
#5 (comment)

Please keep the Subject wording in your answers
This e-mail and any attachments may be confidential. You must not
disclose or use the information contained in this e-mail if you are
not the
intended recipient. If you have received this e-mail in error, please

notify us immediately and delete the e-mail and all copies.

Jean-Marie Simonet / infograf768
Joomla Production Working group
Joomla! Translation Coordination Team

davidhurley pushed a commit that referenced this pull request Oct 9, 2013
Fix proposal for Featured Articles view
mbabker pushed a commit that referenced this pull request Mar 10, 2014
Bakual referenced this pull request in Bakual/joomla-cms May 12, 2014
@maxdel85 maxdel85 mentioned this pull request Mar 6, 2015
photodude added a commit to photodude/joomla-cms that referenced this pull request May 15, 2015
```
PHP Fatal error:  Uncaught exception 'PHP_CodeSniffer_Exception' with message 'Class PHP_CodeSniffer_CommentParser_ClassCommentParser not found' in /home/travis/build/photodude/joomla-cms/build/phpcs/Joomla/Sniffs/Commenting/ClassCommentSniff.php:19
Stack trace:
#0 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer.php(1318): include_once()
#1 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer.php(560): PHP_CodeSniffer->registerSniffs(Array, Array)
joomla#2 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(830): PHP_CodeSniffer->initStandard(Array, Array)
joomla#3 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(95): PHP_CodeSniffer_CLI->process()
joomla#4 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/scripts/phpcs(25): PHP_CodeSniffer_CLI->runphpcs()
joomla#5 {main}
  thrown in /home/travis/build/photodude/joomla-cms/build/phpcs/Joomla/Sniffs/Commenting/ClassCommentSniff.php on line 19
```
photodude added a commit to photodude/joomla-cms that referenced this pull request May 24, 2015
```
PHP Fatal error:  Uncaught exception 'PHP_CodeSniffer_Exception' with message 'Class PHP_CodeSniffer_CommentParser_ClassCommentParser not found' in /home/travis/build/photodude/joomla-cms/build/phpcs/Joomla/Sniffs/Commenting/ClassCommentSniff.php:19
Stack trace:
#0 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer.php(1318): include_once()
#1 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer.php(560): PHP_CodeSniffer->registerSniffs(Array, Array)
joomla#2 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(830): PHP_CodeSniffer->initStandard(Array, Array)
joomla#3 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(95): PHP_CodeSniffer_CLI->process()
joomla#4 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/scripts/phpcs(25): PHP_CodeSniffer_CLI->runphpcs()
joomla#5 {main}
  thrown in /home/travis/build/photodude/joomla-cms/build/phpcs/Joomla/Sniffs/Commenting/ClassCommentSniff.php on line 19
```
photodude added a commit to photodude/joomla-cms that referenced this pull request May 25, 2015
```
PHP Fatal error:  Uncaught exception 'PHP_CodeSniffer_Exception' with message 'Class PHP_CodeSniffer_CommentParser_ClassCommentParser not found' in /home/travis/build/photodude/joomla-cms/build/phpcs/Joomla/Sniffs/Commenting/ClassCommentSniff.php:19
Stack trace:
#0 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer.php(1318): include_once()
#1 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer.php(560): PHP_CodeSniffer->registerSniffs(Array, Array)
joomla#2 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(830): PHP_CodeSniffer->initStandard(Array, Array)
joomla#3 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(95): PHP_CodeSniffer_CLI->process()
joomla#4 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/scripts/phpcs(25): PHP_CodeSniffer_CLI->runphpcs()
joomla#5 {main}
  thrown in /home/travis/build/photodude/joomla-cms/build/phpcs/Joomla/Sniffs/Commenting/ClassCommentSniff.php on line 19
```
photodude added a commit to photodude/joomla-cms that referenced this pull request May 25, 2015
```
PHP Fatal error:  Uncaught exception 'PHP_CodeSniffer_Exception' with message 'Class PHP_CodeSniffer_CommentParser_ClassCommentParser not found' in /home/travis/build/photodude/joomla-cms/build/phpcs/Joomla/Sniffs/Commenting/ClassCommentSniff.php:19
Stack trace:
#0 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer.php(1318): include_once()
#1 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer.php(560): PHP_CodeSniffer->registerSniffs(Array, Array)
joomla#2 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(830): PHP_CodeSniffer->initStandard(Array, Array)
joomla#3 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(95): PHP_CodeSniffer_CLI->process()
joomla#4 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/scripts/phpcs(25): PHP_CodeSniffer_CLI->runphpcs()
joomla#5 {main}
  thrown in /home/travis/build/photodude/joomla-cms/build/phpcs/Joomla/Sniffs/Commenting/ClassCommentSniff.php on line 19
```
photodude added a commit to photodude/joomla-cms that referenced this pull request May 29, 2015
```
PHP Fatal error:  Uncaught exception 'PHP_CodeSniffer_Exception' with message 'Class PHP_CodeSniffer_CommentParser_ClassCommentParser not found' in /home/travis/build/photodude/joomla-cms/build/phpcs/Joomla/Sniffs/Commenting/ClassCommentSniff.php:19
Stack trace:
#0 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer.php(1318): include_once()
#1 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer.php(560): PHP_CodeSniffer->registerSniffs(Array, Array)
joomla#2 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(830): PHP_CodeSniffer->initStandard(Array, Array)
joomla#3 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(95): PHP_CodeSniffer_CLI->process()
joomla#4 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/scripts/phpcs(25): PHP_CodeSniffer_CLI->runphpcs()
joomla#5 {main}
  thrown in /home/travis/build/photodude/joomla-cms/build/phpcs/Joomla/Sniffs/Commenting/ClassCommentSniff.php on line 19
```
photodude added a commit to photodude/joomla-cms that referenced this pull request May 29, 2015
```
PHP Fatal error:  Uncaught exception 'PHP_CodeSniffer_Exception' with message 'Class PHP_CodeSniffer_CommentParser_ClassCommentParser not found' in /home/travis/build/photodude/joomla-cms/build/phpcs/Joomla/Sniffs/Commenting/ClassCommentSniff.php:19
Stack trace:
#0 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer.php(1318): include_once()
#1 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer.php(560): PHP_CodeSniffer->registerSniffs(Array, Array)
joomla#2 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(830): PHP_CodeSniffer->initStandard(Array, Array)
joomla#3 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(95): PHP_CodeSniffer_CLI->process()
joomla#4 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/scripts/phpcs(25): PHP_CodeSniffer_CLI->runphpcs()
joomla#5 {main}
  thrown in /home/travis/build/photodude/joomla-cms/build/phpcs/Joomla/Sniffs/Commenting/ClassCommentSniff.php on line 19
```
photodude added a commit to photodude/joomla-cms that referenced this pull request May 31, 2015
```
PHP Fatal error:  Uncaught exception 'PHP_CodeSniffer_Exception' with message 'Class PHP_CodeSniffer_CommentParser_ClassCommentParser not found' in /home/travis/build/photodude/joomla-cms/build/phpcs/Joomla/Sniffs/Commenting/ClassCommentSniff.php:19
Stack trace:
#0 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer.php(1318): include_once()
#1 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer.php(560): PHP_CodeSniffer->registerSniffs(Array, Array)
joomla#2 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(830): PHP_CodeSniffer->initStandard(Array, Array)
joomla#3 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php(95): PHP_CodeSniffer_CLI->process()
joomla#4 /home/travis/build/photodude/joomla-cms/libraries/vendor/squizlabs/php_codesniffer/scripts/phpcs(25): PHP_CodeSniffer_CLI->runphpcs()
joomla#5 {main}
  thrown in /home/travis/build/photodude/joomla-cms/build/phpcs/Joomla/Sniffs/Commenting/ClassCommentSniff.php on line 19
```
continga pushed a commit to continga/joomla-cms that referenced this pull request Sep 24, 2018
This is the 1st commit message:

First commit which integrates the subform custom field type.

This is the commit message joomla#2:

Rename manifest file for plg_fields_subform

This is the commit message joomla#3:

plg_fields_subform: Improve code comments and made the subform field type optionally non-repeatable.

This is the commit message joomla#4:

Fix not being able to change the type of a subfield.

This is the commit message joomla#5:

Implement a small in-memory renderCache for subform custom fields

This is the commit message joomla#6:

Prepare to load the subfields into a subform custom field directly via their own xml definition.

This is the commit message joomla#7:

After merge with PR joomla#17552 we can now successfully show the subforms options for the different types.

This is the commit message joomla#8:

The subform custom field type doesnt need a default value.

This is the commit message joomla#9:

Implement an option for a subform customfield to disable rendering the field values.

This is the commit message joomla#10:

Remove unused code and set hidden fields to not-required.
continga pushed a commit to continga/joomla-cms that referenced this pull request Sep 24, 2018
This is the 1st commit message:

First commit which integrates the subform custom field type.

This is the commit message joomla#2:

Rename manifest file for plg_fields_subform

This is the commit message joomla#3:

plg_fields_subform: Improve code comments and made the subform field type optionally non-repeatable.

This is the commit message joomla#4:

Fix not being able to change the type of a subfield.

This is the commit message joomla#5:

Implement a small in-memory renderCache for subform custom fields

This is the commit message joomla#6:

Prepare to load the subfields into a subform custom field directly via their own xml definition.

This is the commit message joomla#7:

After merge with PR joomla#17552 we can now successfully show the subforms options for the different types.

This is the commit message joomla#8:

The subform custom field type doesnt need a default value.

This is the commit message joomla#9:

Implement an option for a subform customfield to disable rendering the field values.

This is the commit message joomla#10:

Remove unused code and set hidden fields to not-required.
continga pushed a commit to continga/joomla-cms that referenced this pull request Sep 24, 2018
This is the 1st commit message:

First commit which integrates the subform custom field type.

This is the commit message joomla#2:

Rename manifest file for plg_fields_subform

This is the commit message joomla#3:

plg_fields_subform: Improve code comments and made the subform field type optionally non-repeatable.

This is the commit message joomla#4:

Fix not being able to change the type of a subfield.

This is the commit message joomla#5:

Implement a small in-memory renderCache for subform custom fields

This is the commit message joomla#6:

Prepare to load the subfields into a subform custom field directly via their own xml definition.

This is the commit message joomla#7:

After merge with PR joomla#17552 we can now successfully show the subforms options for the different types.

This is the commit message joomla#8:

The subform custom field type doesnt need a default value.

This is the commit message joomla#9:

Implement an option for a subform customfield to disable rendering the field values.

This is the commit message joomla#10:

Remove unused code and set hidden fields to not-required.
continga pushed a commit to continga/joomla-cms that referenced this pull request Sep 24, 2018
First commit which integrates the subform custom field type.

This is the commit message joomla#2:

Rename manifest file for plg_fields_subform

This is the commit message joomla#3:

plg_fields_subform: Improve code comments and made the subform field type optionally non-repeatable.

This is the commit message joomla#4:

Fix not being able to change the type of a subfield.

This is the commit message joomla#5:

Implement a small in-memory renderCache for subform custom fields

This is the commit message joomla#6:

Prepare to load the subfields into a subform custom field directly via their own xml definition.

This is the commit message joomla#7:

After merge with PR joomla#17552 we can now successfully show the subforms options for the different types.

This is the commit message joomla#8:

The subform custom field type doesnt need a default value.

This is the commit message joomla#9:

Implement an option for a subform customfield to disable rendering the field values.

This is the commit message joomla#10:

Remove unused code and set hidden fields to not-required.

Signed-off-by: Rene Pasing <r.pasing@continga.de>
continga pushed a commit to continga/joomla-cms that referenced this pull request Oct 1, 2018
First commit which integrates the subform custom field type.

This is the commit message joomla#2:

Rename manifest file for plg_fields_subform

This is the commit message joomla#3:

plg_fields_subform: Improve code comments and made the subform field type optionally non-repeatable.

This is the commit message joomla#4:

Fix not being able to change the type of a subfield.

This is the commit message joomla#5:

Implement a small in-memory renderCache for subform custom fields

This is the commit message joomla#6:

Prepare to load the subfields into a subform custom field directly via their own xml definition.

This is the commit message joomla#7:

After merge with PR joomla#17552 we can now successfully show the subforms options for the different types.

This is the commit message joomla#8:

The subform custom field type doesnt need a default value.

This is the commit message joomla#9:

Implement an option for a subform customfield to disable rendering the field values.

This is the commit message joomla#10:

Remove unused code and set hidden fields to not-required.

Signed-off-by: Rene Pasing <r.pasing@continga.de>
wilsonge added a commit that referenced this pull request Mar 27, 2019
hans2103 referenced this pull request in hans2103/joomla-cms Aug 10, 2020
eyvazahmadzada pushed a commit to eyvazahmadzada/joomla-cms that referenced this pull request Jul 15, 2021
Week 1: Generate responsive images
LadySolveig pushed a commit to LadySolveig/joomla-cms that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants