-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebased download system/environment information #7129
Conversation
@phproberto I get both on json and txt the following error code in the beginning of the files:
or simplified: |
@phproberto take a look at phproberto#1 |
@dgt41 I have a applied a different fix in c50f6ef after realising that some extensions manifest may not be cached in the database. The best example I found was plg_weblinks on my own website |
@test ok Thanks @Radek-Suski @phproberto |
@phproberto Should we be outputting the host paths in the PATH, SystemRoot, COMSPEC, WINDIR, error_log, extension_dir, include_path, upload_tmp_dir, and session.save_path variables? |
@roland-d in my opinion anything that gets private info that may involve security issues should be skipped. I don't see issues with paths relative to system libs. Maybe Phil Taylor (I forgot his github username) can help us here. I'll ping him to see if he can check it.
|
This comment was marked as abuse.
This comment was marked as abuse.
@PhilETaylor this is information to export. So I'd see the most likely use case as a user giving this info to extension dev's to replicate environments etc |
This comment was marked as abuse.
This comment was marked as abuse.
I was trying to remove all security relevant data from the output. I agree with Phil. The issue is when someone will post these data in forum etc |
I have removed the information that won't help in any way to replicate enviroments. I think is better that we are more restrictive and then wait for someone asking that some information would be useful. I'd like that a Windows user confirms that there is no private information shared there. |
BTW thanks @PhilETaylor for checking it! |
This comment was marked as abuse.
This comment was marked as abuse.
Tested and it works BUT
|
Thanks for the feedback @brianteeman. I have rebased the PR against latest staging and based in your comments:
|
Any reason not to translate the number of seconds used in the title of the file produced to a real date as this number looks like it is the time elapsed since the epoch time? |
Something like:
|
@phproberto Can you follow up on @infograf768 question? Thanks. |
… for support purposes. The output is a text file which is probably not the best solution. Hope for some input
… for support purposes. The output is a text file which is probably not the best solution. Hope for some input
… for support purposes. The output is a text file which is probably not the best solution. Hope for some input
818c0c0
to
9564e6f
Compare
PR updated and @infograf768 's suggestion to get a human readable date implemented. Thanks! |
I have tested this item ✅ successfully on c823c3e This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7129. |
I have tested this item ✅ successfully on c823c3e As those informations are for supporters, some toughts of me as a forum moderator/supporter: Due to extensions, important infos for supporting are (beside others of course):
Core Components whow are maintained by the core are mostly irrelevant for support. And Modules too, as they 'living' all in their own 'universe', not interfere/manipulate with other extension parts. Templates who are not involved are irrelevant. But I think that's all stuff for another rainy day 😄 But for the first implementation I would advise to add the publish state at least for plugins and modules, and ordering of the plugins groupwise + ordering ASC Just my 20 cents. But anyway, it's a helpful feature for the future. Thanks for the work. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7129. |
Thanks lets RTC here and you can send you improvments with another PR or open a new issue for it ok? Thanks. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7129. |
Sure, that's what I mean with |
This is a rebased version of #6021 See description there
I have added suggestions by @roland-d and small code style fixes.
#6021
Implementing a possibility to download system/environment information for support purposes.
The output is a text file which is probably not the best solution. Hope for some input.
It adds a button in "administrator/index.php?option=com_admin&view=sysinfo" which allows to create a text file with all relevant settings.
All sensitive informations should have been removed.