#181 - ensure bytes are always returned from .body() method #182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this closes #181.
All tests pass, and I have tested the solution on a live lambda function being severed by ALB.
The type annotations suggest that
def body(self) -> bytes:
should ALWAYS return bytes. However the code (and tests) sometimes returns None. In these cases I forced the None to return an empty byte string:b""
. As a result most of the methods now look like this:If that is incorrect I can update my PR to reflect that
bytes
ORNone
can be returned fromdef body(self)
and remove the code that forces None to become b"".Let me know if I should add anything else! Have loved using Mangum these past few months, made moving my Django application to serverless pretty easy.