also require name property (devcontainers#447)

joshspicer · Mar 15, 2023 · e3d12b3 · e3d12b3
1 parent 1473080
commit e3d12b3
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/spec-node/collectionCommonUtils/packageCommandImpl.ts b/src/spec-node/collectionCommonUtils/packageCommandImpl.ts
@@ -92,8 +92,8 @@ export async function packageSingleFeatureOrTemplate(args: PackageCommandInput,
 	}
 
 	const metadata = jsonc.parse(await readLocalFile(jsonPath, 'utf-8'));
-	if (!metadata.id || !metadata.version) {
-		output.write(`${collectionType} is missing an id or version in its devcontainer-${collectionType}.json`, LogLevel.Error);
+	if (!metadata.id || !metadata.version || !metadata.name) {
+		output.write(`${collectionType} is missing one of the following required properties in its devcontainer-${collectionType}.json: 'id', 'version', 'name'.`, LogLevel.Error);
 		return;
 	}
 
@@ -212,8 +212,8 @@ export async function packageCollection(args: PackageCommandInput, collectionTyp
 			await tarDirectory(tmpSrcDir, archiveName, outputDir);
 
 			const metadata = jsonc.parse(await readLocalFile(jsonPath, 'utf-8'));
-			if (!metadata.id || !metadata.version) {
-				output.write(`${collectionType} '${c}' is missing an id or version in its ${devcontainerJsonName}`, LogLevel.Error);
+			if (!metadata.id || !metadata.version || !metadata.name) {
+				output.write(`${collectionType} '${c}' is missing one of the following required properties in its ${devcontainerJsonName}: 'id', 'version', 'name'.`, LogLevel.Error);
 				return;
 			}
 			metadatas.push(metadata);