Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalidate cache maps #143

Merged
merged 7 commits into from
Sep 17, 2023
Merged

Invalidate cache maps #143

merged 7 commits into from
Sep 17, 2023

Conversation

jp7677
Copy link
Owner

@jp7677 jp7677 commented Sep 12, 2023

This should especially improve test isolation.

@jp7677 jp7677 force-pushed the invalidate-caches branch 2 times, most recently from 8a48306 to 5c5694e Compare September 15, 2023 06:35
@jp7677
nvapi-disp: Remove log statement
ac354ed 
It doesn't add much since it is always written for
struct version 2 i.c.w. setting data.
@jp7677 jp7677 marked this pull request as ready for review September 15, 2023 06:43
@jp7677
sysinfo: Clear D3D11 and D3D12 cache maps
a6f6ca0 
Let's clean up everything when destroying the registry.
@jp7677 jp7677 changed the title Invalidate caches Invalidate cache maps Sep 15, 2023
Saancreed
Saancreed approved these changes Sep 16, 2023
View reviewed changes
Copy link
Collaborator

@Saancreed Saancreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cache cleaning and tests changes are 👌, I'm just not sure how I feel about the log message. But probably it doesn't matter that much.

src/d3d12/nvapi_d3d12_device.cpp Outdated Show resolved Hide resolved
src/nvapi_disp.cpp Show resolved Hide resolved
@jp7677 jp7677 merged commit 66a009f into master Sep 17, 2023
1 check passed
@jp7677 jp7677 deleted the invalidate-caches branch October 8, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saancreed Saancreed Saancreed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jp7677 @Saancreed