Spoof Pascal for non-NVIDIA propietary driver #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents unexpected behavior when GetMonitorInfo is called with nullptr, like in the tests.
Saancreed
reviewed
Oct 7, 2023
There was a problem hiding this comment.
There shouldn't be any side effects since DLSS requires at least Turing.
I'd still spoof those GPUs as Pascal for two reasons:
- To reduce the likelyhood of some games suddenly starting to pop some annoying "This is an ancient and totally unsupported GPU!" warnings.
- Because of https://github.com/NVIDIAGameWorks/Streamline/blob/main/source/plugins/sl.reflex/reflexEntry.cpp#L170-L182
This helps to use LatencyFlex on AMD GPUs with Streamline. DLSS requires at least Turing, so no side effects with that.
jp7677
force-pushed
the
spoof-pascal-for-non-nv
branch
from
4b74d86
to
ed4338f
Compare
jp7677
changed the title
Saancreed
approved these changes
Oct 7, 2023
|
Works as expected - allows the usage of latencyflex2 so latencyflex should also work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not that cool to do this, but seems to help to use LatencyFlex on AMD GPUs with Streamline because
NvAPI_GPU_GetArchInfono longer fails.There shouldn't be any side effects since DLSS requires at least Turing.