mvcc: add metrics to characterize backend expensive reads #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingyih
force-pushed
the
expensive_read_instrumentation
branch
2 times, most recently
from
676d2dd
to
324330c
Compare
jpbetz
requested changes
Feb 12, 2019
mvcc/backend/backend.go
Outdated
| @@ -315,6 +316,8 @@ func (b *backend) run() { | |||
| if b.batchTx.safePending() != 0 { | |||
| b.batchTx.Commit() | |||
| } | |||
| batchIntervalSec.Observe(time.Since(start).Seconds() * 1e3) | |||
There was a problem hiding this comment.
I believe .Seconds() already performs the needed unit conversion and we don't need the * 1e3.
mvcc/backend/metrics.go
Outdated
| batchIntervalSec = prometheus.NewHistogram(prometheus.HistogramOpts{ | ||
| Namespace: "etcd_debugging", | ||
| Subsystem: "backend", | ||
| Name: "batch_interval_duration_milliseconds", |
There was a problem hiding this comment.
variable name suggests seconds but metric name suggests milliseconds. For prometheus it's okay to use seconds here. There's a convention: https://prometheus.io/docs/practices/naming/#base-units
mvcc/backend/metrics.go
Outdated
|
|
||
| // lowest bucket start of upper bound 0.1 msec (10 us) with factor 2 | ||
| // highest bucket start of 0.1 msec * 2^13 == 819.2 msec | ||
| Buckets: prometheus.ExponentialBuckets(0.1, 2, 14), |
There was a problem hiding this comment.
If we switch to seconds, we'll need to update the buckets to match.
jingyih
force-pushed
the
expensive_read_instrumentation
branch
from
324330c
to
51e6dce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics added:
etcd_debugging_mvcc_put_total
etcd_debugging_mvcc_put_duration_seconds
etcd_debugging_mvcc_range_total
etcd_debugging_mvcc_range_duration_seconds
etcd_debugging_mvcc_committed_read_total
etcd_debugging_mvcc_committed_read_duration_seconds
etcd_debugging_backend_batch_interval_duration_seconds