Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try adding nodeRef #1140

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

try adding nodeRef #1140

wants to merge 3 commits into from

Conversation

quinn
Copy link

@quinn quinn commented Jan 4, 2023

attempt to fix #1137

@jquense
Copy link
Owner

jquense commented Jan 9, 2023

if this works seems good to me, any reason it's still in a draft?

@quinn quinn marked this pull request as ready for review January 9, 2023 22:36
@quinn
Copy link
Author

quinn commented Jan 9, 2023

@jquense looks like I need to refactor because its a class-based component.

@bt
Copy link

bt commented Jan 11, 2023

Is useRef the same as React.createRef?

You can use createRef in class-based components.

@quinn
Copy link
Author

quinn commented Jan 12, 2023

@bt yes, it is the same. I updated to use createRef. @jquense what is a good way to test this out?

@jquense
Copy link
Owner

jquense commented Jan 13, 2023

Try running the docs but in strict mode?

@bt
Copy link

bt commented Feb 3, 2023

@quinn Did you have any luck?

@astralmedia
Copy link

Any movement on this? Would love to clean that last error up on my logs :)

@quinn
Copy link
Author

quinn commented Apr 19, 2023

@astralmedia PR should work, I haven't had a chance to run the docs in strict mode as advised

@quinn
Copy link
Author

quinn commented Apr 19, 2023

also, I can't see why the build failed? says, expired

@quinn
Copy link
Author

quinn commented Apr 19, 2023

getting this error when I try to run docs:

node:internal/crypto/hash:71
  this[kHandle] = new _Hash(algorithm, xofLen);
                  ^

Error: error:0308010C:digital envelope routines::unsupported

@BubuMVX
Copy link

BubuMVX commented Jan 11, 2024

Hi, can this PR be merged or does it needs more work?
I face the issue it should be fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

findDOMNode is deprecated in StrictMode - error
5 participants