forked from PHPMailer/PHPMailer
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
DKIMTest::testDKIMSignOpenSSLNotAvailable(): fix the test
As things were, the `DKIMTest::testDKIMSignOpenSSLNotAvailable()` could not pass as the `DKIMTest` class sets the `USE_EXCEPTIONS` class constant to `true`, which means the method would fail on an exception. As this test is specifically about testing the behaviour when exceptions are _disabled_, the test needs to be in its own test class, which sets `USE_EXCEPTIONS` to `false`. That should allow the test to run properly and to pass.
- Loading branch information
Showing
2 changed files
with
47 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
<?php | ||
|
||
/** | ||
* PHPMailer - PHP email transport unit tests. | ||
* PHP version 5.5. | ||
* | ||
* @author Marcus Bointon <phpmailer@synchromedia.co.uk> | ||
* @author Andy Prevost | ||
* @copyright 2012 - 2020 Marcus Bointon | ||
* @copyright 2004 - 2009 Andy Prevost | ||
* @license https://www.gnu.org/licenses/old-licenses/lgpl-2.1.html GNU Lesser General Public License | ||
*/ | ||
|
||
namespace PHPMailer\Test\PHPMailer; | ||
|
||
use PHPMailer\PHPMailer\PHPMailer; | ||
use PHPMailer\Test\TestCase; | ||
|
||
/** | ||
* Test DKIM signing functionality. | ||
* | ||
* @group dkim | ||
*/ | ||
final class DKIMWithoutExceptionsTest extends TestCase | ||
{ | ||
/** | ||
* Whether or not to initialize the PHPMailer object to throw exceptions. | ||
* | ||
* @var bool|null | ||
*/ | ||
const USE_EXCEPTIONS = false; | ||
|
||
/** | ||
* Verify behaviour of the DKIM_Sign method when Open SSL is not available and exceptions is disabled. | ||
* | ||
* @covers \PHPMailer\PHPMailer\PHPMailer::DKIM_Sign | ||
*/ | ||
public function testDKIMSignOpenSSLNotAvailable() | ||
{ | ||
if (extension_loaded('openssl')) { | ||
$this->markTestSkipped('Test requires OpenSSL *not* to be available'); | ||
} | ||
|
||
$signature = $this->Mail->DKIM_Sign('foo'); | ||
self::assertSame('', $signature); | ||
} | ||
} |