-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storybook.js.org #9283
storybook.js.org #9283
Conversation
👋 @shilman could I get a +1 from you on this as you're the previous requestor for the subdomain? |
Thanks for checking @MattIPv4 !! I'm good with this change ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Commit valid, site has content based on https://storybook-frontpage.netlify.app/
I trust that your site is configured ready to work with the requested js.org subdomain.
Sorry for the long delay... I've just made the change in JS.ORGs zonefile. But it looks like something is not correct... Let me know if I should revert the change. |
@kylegach I reverted the change for now to avoid downtime for your page. Should we set up an appointment when I should make the change again to give you a chance to react on your side? |
@indus — Thank you. We believe it's an SSL issue which we have resolved on our end. In order for it take effect, we need the DNS to point to Netlify servers, so please make the change again. |
I've just made the change again (and will have an eye on this PR now) |
http://storybook.js.org/ now gets served from Netlify for me (that was not the case the first time I tried). |
Just in case the cert issue won't fix I can also offer to turn on the Cloudflare proxy for your subdomain; it would come with Universal-SSL provided by Cloudflare. |
@indus — Thanks for your assistance. Unfortunately, we need you to revert again. We're struggling to find the exact issue, and will get some help before trying again. |
I've just reverted the record in the zonefile. |
As I'm living in UTC +2 timezone I will be available only for another ~3 hours. |
Really appreciate your help and accommodations, @indus. We're going to triple check everything on our side before requesting this again. Both to respect your time and minimize downtime. Perhaps we should close this PR and open another when we're ready? |
Thanks @indus. I think we'll pause the update for now until we have a bit more clarity on Netlify. We just can't have our site down waiting for their SSL to propagate. We could not understand what went wrong in the process. |
No problem. Take your time. And good luck finding a solution for a switch with a short downtime.Am 26.09.2024 19:56 schrieb Charles de Dreuille ***@***.***>:
Thanks @indus. I think we'll pause the update for now until we have a bit more clarity on Netlify. We just can't have our site down waiting for their SSL to propagate. We could not understand what went wrong in the process.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Lets close this for now - but feel free to restart the subdomain migration whenever you want. |
Thanks for your patience @indus |
Reverts #9119, because we decided to stick with Netlify (although with a different site name).