Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybook.js.org #9283

Closed
wants to merge 1 commit into from
Closed

Conversation

kylegach
Copy link
Contributor

Reverts #9119, because we decided to stick with Netlify (although with a different site name).

@MattIPv4 MattIPv4 changed the title Update cname for Storybook storybook.js.org Sep 25, 2024
@MattIPv4
Copy link
Member

👋 @shilman could I get a +1 from you on this as you're the previous requestor for the subdomain?

@shilman
Copy link
Contributor

shilman commented Sep 25, 2024

Thanks for checking @MattIPv4 !! I'm good with this change ❤️

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, site has content based on https://storybook-frontpage.netlify.app/

I trust that your site is configured ready to work with the requested js.org subdomain.

@MattIPv4 MattIPv4 added change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages labels Sep 25, 2024
@indus
Copy link
Member

indus commented Sep 26, 2024

Sorry for the long delay...

I've just made the change in JS.ORGs zonefile. But it looks like something is not correct...

Let me know if I should revert the change.

@indus indus added the error The page requested returns an error label Sep 26, 2024
@indus
Copy link
Member

indus commented Sep 26, 2024

@kylegach I reverted the change for now to avoid downtime for your page. Should we set up an appointment when I should make the change again to give you a chance to react on your side?

@kylegach
Copy link
Contributor Author

@indus — Thank you. We believe it's an SSL issue which we have resolved on our end. In order for it take effect, we need the DNS to point to Netlify servers, so please make the change again.

@indus
Copy link
Member

indus commented Sep 26, 2024

I've just made the change again (and will have an eye on this PR now)

@indus
Copy link
Member

indus commented Sep 26, 2024

http://storybook.js.org/ now gets served from Netlify for me (that was not the case the first time I tried).
SSL still has problems

@indus
Copy link
Member

indus commented Sep 26, 2024

Just in case the cert issue won't fix I can also offer to turn on the Cloudflare proxy for your subdomain; it would come with Universal-SSL provided by Cloudflare.

@kylegach
Copy link
Contributor Author

@indus — Thanks for your assistance. Unfortunately, we need you to revert again.

We're struggling to find the exact issue, and will get some help before trying again.

@indus
Copy link
Member

indus commented Sep 26, 2024

I've just reverted the record in the zonefile.

@indus
Copy link
Member

indus commented Sep 26, 2024

As I'm living in UTC +2 timezone I will be available only for another ~3 hours.

@kylegach
Copy link
Contributor Author

Really appreciate your help and accommodations, @indus. We're going to triple check everything on our side before requesting this again. Both to respect your time and minimize downtime. Perhaps we should close this PR and open another when we're ready?

@cdedreuille
Copy link

Thanks @indus. I think we'll pause the update for now until we have a bit more clarity on Netlify. We just can't have our site down waiting for their SSL to propagate. We could not understand what went wrong in the process.

@indus
Copy link
Member

indus commented Sep 26, 2024 via email

@indus
Copy link
Member

indus commented Sep 28, 2024

Perhaps we should close this PR and open another when we're ready?

Lets close this for now - but feel free to restart the subdomain migration whenever you want.

@indus indus closed this Sep 28, 2024
@shilman
Copy link
Contributor

shilman commented Sep 29, 2024

Thanks for your patience @indus

@kylegach kylegach mentioned this pull request Oct 10, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change This PR/issue is regarding making a change to an existing subdomain error The page requested returns an error external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants