Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybook.js.org #9321

Merged
merged 4 commits into from
Oct 11, 2024
Merged

storybook.js.org #9321

merged 4 commits into from
Oct 11, 2024

Conversation

kylegach
Copy link
Contributor

The content is at storybook-frontpage.netlify.app.

Per #9320, the test worked, so this PR makes the change on the real domain.

Making this a draft PR for now, to avoid premature merging.

@indus and I have coordinated to merge this on October 11, 2024 at 15:30 UTC.

@kylegach kylegach marked this pull request as ready for review October 11, 2024 14:53
@indus indus added change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages labels Oct 11, 2024
@indus
Copy link
Member

indus commented Oct 11, 2024

@kylegach I'm ready I make the change at 15:30 UTC.

@indus
Copy link
Member

indus commented Oct 11, 2024

Just made change. Distribution to every node in the CF global network may take a minute.

@kylegach
Copy link
Contributor Author

It's looking good! Thank you so much for your generous help, Stefan.

@indus
Copy link
Member

indus commented Oct 11, 2024

@kylegach It's working for me.

May I ask you to change the PR according to this: https://github.com/js-org/js.org/actions/runs/11294549413/job/31416661395?pr=9321
(the CI expects netlify.app instead of netlify.com because of this ; I can keep it as .com in the zonefile if you prefer).

@indus
Copy link
Member

indus commented Oct 11, 2024

As you have closed the other PR I will have to remove the storybook-test2 subdomain from the zonefile; to keep it in sync.

@indus indus closed this Oct 11, 2024
@indus indus reopened this Oct 11, 2024
@kylegach
Copy link
Contributor Author

May I ask you to change the PR according to this: js-org/js.org/actions/runs/11294549413/job/31416661395?pr=9321
(the CI expects netlify.app instead of netlify.com ; I can keep it as .com in the zonefile if you prefer).

Done!

As you have closed the other PR I will have to remove the storybook-test2 subdomain from the zonefile; to keep it in sync.

Yes, we would appreciate that. Thank you.

@indus indus merged commit 9689ca8 into js-org:master Oct 11, 2024
1 check passed
@indus
Copy link
Member

indus commented Oct 11, 2024

should I try to make the .com -> .app change in the zonefile to keep it in perfect sync? ...or better leave it as is now that it works?

There is this comment: https://answers.netlify.com/t/deprecating-automatic-com-redirects/115442
But I'm really not sure this is also the new default for apex-loadbalancer.netlify(.com|.app)

@kylegach
Copy link
Contributor Author

@indus — If it's alright, let's leave the zonefile as it is (using .com). Everywhere I found that apex-loadbalancer.netlify.com URL documented, it uses .com.

Do you have any sites configured using apex-loadbalancer.netlify.app?

@kylegach
Copy link
Contributor Author

Oh. Then sure, let's keep it in sync while we're both actively monitoring and available. Thanks.

@indus
Copy link
Member

indus commented Oct 11, 2024

Thanks. Just made the change to .app

@kylegach
Copy link
Contributor Author

✅ All still looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change This PR/issue is regarding making a change to an existing subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants