Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django 3.2 trove classifier #1005

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Add Django 3.2 trove classifier #1005

merged 1 commit into from
Sep 9, 2021

Conversation

jschneier
Copy link
Owner

No description provided.

@amureki
Copy link

amureki commented May 5, 2021

@jschneier hey Josh!
I was debugging some issue with one of the latest Django releases (3.2.1) and noticed that django-storages is not yet have Django 3.2+ support (CI).

Seeing this PR issue - I wonder if those were some flaky problems with pip/wheel setup and recent cryptography releases.
I think, we might want to try to restart this build to see if it was resolved.

Is there anything I can assist you with to get this going?
Many thanks for maintaining this project!

Best,
Rust

@adamzap
Copy link

adamzap commented Jun 1, 2021

@jschneier Any update on Django v3.2 support? Is there any way your users can help push it forward? Thanks!

@jschneier
Copy link
Owner Author

@adamzap CI needs to work, we're dead in the water without it.

@jschneier jschneier force-pushed the fix-ci branch 2 times, most recently from 9896400 to 31a57c8 Compare June 6, 2021 18:22
@jschneier
Copy link
Owner Author

CI is fixed but tests are broken by latest Django changes.

@adamzap
Copy link

adamzap commented Jun 8, 2021

I want to help, but I'm having trouble getting a development environment running for this project. Do you have instructions somewhere?

@allanlewis
Copy link

@adamzap Try tox -e py38-django32 --develop, you should just need Python 3.8 and tox for that to work. tox -a will list the available test configurations.

It seems that tests are failing on Django 2.2 as well as 3.2 😕

@mariajgrimaldi
Copy link
Contributor

mariajgrimaldi commented Aug 25, 2021

Hey, @adamzap @jschneier @amureki @allanlewis! I hope you're doing great!

I'm reaching out to help as part of the Open edX community effort to upgrade Django to Django 3.2 in the Open edX platform. That includes, among other things, updating its dependencies. Of course, django-storages is one of them. Here is the issue!

I'm thrilled to help you in whatever you need to finish this issue. Please let me know what's its status!

@adamzap
Copy link

adamzap commented Aug 27, 2021

@jschneier I was able to fix this, but then I realized that #1042 is already open. That's almost the same fix that I came up with.

Django fixed a security issue, and it changed which exception gets thrown in the failing code from ValueError to SuspiciousFileOperation. The only issue I see with #1042 is that it's asserting that SuspiciousOperation is raised instead of SuspiciousFileOperation, which is more specific.

So, I think if you get something like #1042 in and then get this PR in, Django v3.2 will be supported. I can open a new PR that does everything, if you want.

@jschneier
Copy link
Owner Author

Annoyingly, CI is not running because Travis no longer supports open source in the same way.

@adamzap
Copy link

adamzap commented Sep 4, 2021

@jschneier Are you interested in switching to GitHub Actions?

@jschneier
Copy link
Owner Author

@adamzap yup

@mariajgrimaldi
Copy link
Contributor

mariajgrimaldi commented Sep 6, 2021

Hi there! @adamzap @jschneier let me know if you need help!

@jschneier
Copy link
Owner Author

jschneier commented Sep 6, 2021 via email

@mariajgrimaldi
Copy link
Contributor

Hi there! @adamzap @jschneier

I opened this PR: #1051. Any suggestions are welcome!

@jschneier jschneier changed the title Fix CI and add Django 3.2 Add Django 3.2 Trove classifier Sep 9, 2021
@jschneier jschneier changed the title Add Django 3.2 Trove classifier Add Django 3.2 trove classifier Sep 9, 2021
@jschneier jschneier merged commit f65d5a0 into master Sep 9, 2021
@jschneier jschneier deleted the fix-ci branch September 9, 2021 02:38
jschneier added a commit that referenced this pull request Sep 19, 2021
mlazowik pushed a commit to qedsoftware/django-storages that referenced this pull request Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants