Replace S3Boto3Storage._compress_content with a streaming implementation #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vainu-arto
force-pushed
the
streaming-compression
branch
2 times, most recently
from
34e5c95
to
6f273e9
Compare
The original version reads the entire content in one go, compresses and places it into a buffer in memory. This limits both the possible size of the file that can be saved and compressed, and also the performance of the transfer.
vainu-arto
force-pushed
the
streaming-compression
branch
from
6f273e9
to
38b32bf
Compare
|
This handles setting |
|
Yes, mtime in the header will always be zero. In my understanding it isn't actually possible to set it to any other value when allowing zlib to generate the header itself. |
|
How was this tested? |
|
I ran random sets of data through it and the stdlib GzipFile, decompressed (with GzipFile and system gzip) and compared the output between each other and the original. I couldn't find a way to make it produce output that could not be decompressed or would differ from the original. |
|
Thanks |
mlazowik
pushed a commit
to qedsoftware/django-storages
that referenced
this pull request
Mar 9, 2022
…#1061) The original version reads the entire content in one go, compresses and places it into a buffer in memory. This limits both the possible size of the file that can be saved and compressed, and also the performance of the transfer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original version reads the entire content in one go, compresses and
places it into a buffer in memory. This limits both the possible size of
the file that can be saved and compressed, and also the performance of the
transfer.