Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gcloud] Fix saving already gzipped files & tests #1366

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

jschneier
Copy link
Owner

A change in Google Cloud broke the test suite due to aggressive mocking of the credentials and exposed a bug in how already gzipped files are handled as a side effect.

With this change if the encoding is already set (such as gzip) we will skip the gzipping part which was the original intent anyway.

@jschneier jschneier merged commit ce34cf1 into master Mar 15, 2024
19 checks passed
@jschneier jschneier deleted the josh/fix-gcloud-gzip-again branch March 15, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant