Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for already gzipped content to S3 storage to the boto3 backend #263 #264

Merged
merged 3 commits into from
Apr 13, 2017

Conversation

ldng
Copy link
Contributor

@ldng ldng commented Feb 2, 2017

…ackend #263

@jschneier
Copy link
Owner

Hello, the code changes looks okay but the test fails. The way boto3 adds the data is not the same as the way boto does, fix that and then I can merge.

@codecov-io
Copy link

codecov-io commented Apr 13, 2017

Codecov Report

Merging #264 into master will increase coverage by 0.34%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   72.48%   72.83%   +0.34%     
==========================================
  Files          10       10              
  Lines        1381     1384       +3     
==========================================
+ Hits         1001     1008       +7     
+ Misses        380      376       -4
Impacted Files Coverage Δ
storages/backends/s3boto3.py 85.13% <50%> (+0.17%) ⬆️
storages/backends/apache_libcloud.py 0% <0%> (ø) ⬆️
storages/backends/s3boto.py 88.19% <0%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ad4890...67fb968. Read the comment docs.

@ldng
Copy link
Contributor Author

ldng commented Apr 13, 2017

Hi,

sorry took me so long but I got busy and forgot about the PR.
I fixed the test but I'm not familiar with codecov and do not know how to handle codecov/patch failure.

@jschneier
Copy link
Owner

Don't worry about that part. Test coverage is something that I need to work on in general. Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants