Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added project support to GCS through LibCloud #269

Merged
merged 1 commit into from
Apr 12, 2017

Conversation

slightfoot
Copy link
Contributor

Please see the docs here for reference to this paremter.
https://libcloud.readthedocs.io/en/latest/compute/drivers/gce.html

Perhaps the docs should be updated to reflect this.

@codecov-io
Copy link

codecov-io commented Feb 19, 2017

Codecov Report

Merging #269 into master will decrease coverage by -0.07%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
- Coverage   59.32%   59.25%   -0.07%     
==========================================
  Files          17       17              
  Lines        1694     1696       +2     
==========================================
  Hits         1005     1005              
- Misses        689      691       +2
Impacted Files Coverage Δ
storages/backends/apache_libcloud.py 0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 880ffc5...7750fd1. Read the comment docs.

@jschneier
Copy link
Owner

jschneier commented Apr 12, 2017

The project is optional (will default otherwise) but probably good to have the option.

@jschneier jschneier merged commit 6797d93 into jschneier:master Apr 12, 2017
jschneier added a commit that referenced this pull request Apr 12, 2017
@slightfoot
Copy link
Contributor Author

slightfoot commented Apr 12, 2017

@jschneier thanks for the merge. libcloud docs mentioned above refer to this parameter as required, but you probably know better.

Just looking at my commit it might be better to use the provider as the extra_kwargs default value. This would allow for optional parameters to be passed across from provider config to drivers.

@jschneier
Copy link
Owner

Yeah I agree. What we currently have can only lead to madness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants