-
-
Notifications
You must be signed in to change notification settings - Fork 859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AWS_SESSION_TOKEN and AWS_SECURITY_TOKEN #283
Conversation
A few questions:
|
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
=========================================
+ Coverage 72.28% 72.48% +0.2%
=========================================
Files 10 10
Lines 1371 1381 +10
=========================================
+ Hits 991 1001 +10
Misses 380 380
Continue to review full report at Codecov.
|
I just encountered the same issue, and was glad to see someone had already done the legwork. I've also verified that this solves my problem on Lambda. |
I've verified this in my project as well, thanks Bryan! Should fix #282 too. |
Looks good! |
@bxm156 re: your questions. The docs are overdue for an overhaul. Authentication should be given its own section. I think relying on just the environment variables is likely better in this case but I need to read the aws docs again just to make sure. |
Oof. This only sets |
Crappy fix in 2529729 |
Ah, sorry about that, I was planning on writing some tests for this but never got around to it :( |
Add support for reading the AWS_SESSION_TOKEN and AWS_SECURITY_TOKEN from the environment.
Verified this works as expected in AWS Lambda.