Detect Content-Type when content_type property is null #407
Conversation
|
The failure is unrelated to my changes as far as I can tell. Perhaps a cache issue with pip on Travis CI? |
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
==========================================
+ Coverage 76.05% 76.08% +0.03%
==========================================
Files 11 11
Lines 1566 1568 +2
==========================================
+ Hits 1191 1193 +2
Misses 375 375
Continue to review full report at Codecov.
|
|
@jschneier Updated with a fix for failing tests on master. paramiko now requires the enum library, which wasn't added to Python 3 until Python 3.4. I updated tox to include the dependency for python 3.3 tests. |
|
Works for me also - thanks @bxm156 |
|
This pull request fix the issue I'm having too. |
|
@jschneier this commit fixes an issue that is giving headaches to many developers, any chance to get it merged into master? Well done @bxm156 |
|
Perhaps @jleclanche could help get this merged? |
|
Sure. I can't make releases though. |
|
This resolves an issue plaguing Django CMS users. @jschneier Any thoughts on a release? |
|
Thanks for the ping, sure. @jleclanche thanks for the assist on the maintenance. I'm close to getting to the point where I can spend 1-2 full days/month on open source. |
|
@jschneier Have you thought about moving django-storages to jazzband? I've done it for one of my django projects and it's a huge weight off my mind |
|
I’ve thought about it, yeah. And yeah, there is some guilt with my lack of maintenance here. Frankly I think the codebase I inherited is a bit of a disaster (the testing and the settings especially). My hope is to find the time to do that right and then move it over but I just don’t think they’d even take it now (I believe a previous contributor approached them maybe a year ago).
… On Mar 26, 2018, at 5:02 PM, Jerome Leclanche ***@***.***> wrote:
@jschneier <https://github.com/jschneier> Have you thought about moving django-storages to jazzband? I've done it for one of my django projects and it's a huge weight off my mind
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#407 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACJB2D6U8fJTAFaDieiuK0ywsQOro38iks5tiVeBgaJpZM4P5iP_>.
|
|
@jschneier Worth giving it another shot. No project's perfect, but this one is used by a lot of people, and at the end of the day reducing bus factor is the whole goal. |
|
Fair. Just made a release as well.
… On Mar 26, 2018, at 5:11 PM, Jerome Leclanche ***@***.***> wrote:
@jschneier <https://github.com/jschneier> Worth giving it another shot. No project's perfect, but this one is used by a lot of people, and at the end of the day reducing bus factor is the whole goal.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#407 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACJB2CFzGC_353mVdGqfKnKm0HhkQ_BGks5tiVmHgaJpZM4P5iP_>.
|
|
Thanks @jschneier! Side Question: |
|
Absolutely.
Would like to get it a place where this is: https://github.com/etianen/django-s3-storage
In particular the live testing of pull requests with real credentials. It’s too easy to break things using mocks since this library is all about using the actual underlying library and what is placed in the provider. Ideally I’d like to make some base class (maybe BaseCloudStorageBackend?) which can clean up some of the duplicated logic across backends/make it easier to add new ones (someone mentioned Digital Ocean for example a few months ago I think). Whether or not ftp/sftp gets pulled out at that point is pretty arbitrary. Also would deprecate s3boto.py (not boto3 obviously) and then remove that + gs.py. So quite a lot to do altogether.
… On Mar 26, 2018, at 5:55 PM, Bryan Marty ***@***.***> wrote:
Thanks @jschneier <https://github.com/jschneier>!
Side Question:
What work do you think is needed in order to make this project viable for something like Jazzband?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#407 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACJB2DvoQ82TJBUneQ3G4vmWCNvuDxf_ks5tiWPfgaJpZM4P5iP_>.
|
|
FWIW I don't think any of those things are required to get into jazzband. Ci and an easy to run test suite so that pull requests can be merged without too deep an understanding of the codebase is what's important. Regarding testing with real credentials, it's certainly nice to have the possibility, but in CI I recommend "real" mock implementations. Either stuff like moto or minio for S3, for example. |
|
I recall breaking the Dropbox backend (1 of many I believe) because we were mocking out the client library. S3 probably has sufficient adoption that full mock libraries exist for it but I don’t think that goes for the others. And then when we had that s3v4 vs s3 issue (something along those lines) that was mostly evident with different regions (aka not just Virginia)…which is truthfully further than I was going to go regardless.
… On Mar 26, 2018, at 8:44 PM, Jerome Leclanche ***@***.***> wrote:
FWIW I don't think any of those things are required to get into jazzband. Ci and an easy to run test suite so that pull requests can be merged without too deep an understanding of the codebase is what's important.
Regarding testing with real credentials, it's certainly nice to have the possibility, but in CI I recommend "real" mock implementations. Either stuff like moto <https://github.com/spulec/moto> or minio <https://github.com/minio/minio> for S3, for example.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#407 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACJB2NUv3_WaTIWUF2veltQpCdRRwvXUks5tiYtRgaJpZM4P5iP_>.
|
|
@jschneier Thank you for the prompt response! It was a pleasant surprise. |
Fallback on other content-type detection methods when the content_type property is None
Fixes #406