Make sure that we read the file from the beginning in Azure Storage backend #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1kola
commented
Aug 20, 2018
| @@ -88,6 +88,7 @@ def _save(self, name, content): | |||
| else: | |||
| content_type = mimetypes.guess_type(name)[0] | |||
|
|
|||
| content.seek(0) | |||
| if hasattr(content, 'chunks'): | |||
| content_data = b''.join(chunk for chunk in content.chunks()) | |||
There was a problem hiding this comment.
As far as I understand content is a file-like object, but I have no idea about this case. Is it something Azure-specific? Is it ok to call seek on content before this?
|
Azure storage was massively rewritten and merged in since then. However this does appear to be a real issue and I have opened #582 to resolve it. Thanks for the PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same as #561, but for Azure Storage backend
I'm not familiar with Azure Storage and I'm not using it. Also there are no tests for this backend, so please, review this carefully :)