Handle context cancellation to shutdown the exporter #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsAreku
force-pushed
the
context_cancel
branch
from
fb0be7e
to
c3d7b3b
Compare
ThisIsAreku
force-pushed
the
context_cancel
branch
from
c3d7b3b
to
f94d6d3
Compare
ThisIsAreku
force-pushed
the
context_cancel
branch
from
f94d6d3
to
93d3b4f
Compare
|
oh, looking forward to this ! |
|
@jsclayton can you review this please ? @johntdyer Until it's merged I've built and pushed this branch on my fork, so you can use this docker image |
jsclayton
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
I've added context to handle the ctrl+c interrupt across the app
This gracefully close the metrics http server and the plex event websocket.
This is also a workaround for #6 and #16 as it terminate the program if there is a error on the websocket connection