Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI GH action #48

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Fix CI GH action #48

merged 2 commits into from
Apr 9, 2024

Conversation

carpasse
Copy link
Contributor

@carpasse carpasse commented Apr 9, 2024

@carpasse
use nyc instead of istanbul and fix npm config for newer node versions
0833abb 
also removed node 0.6 from ci action becuase it can not be installed on ubuntu 20
@carpasse
add missing node versions to ci action
1f33e7d
@carpasse
Copy link
Contributor Author

carpasse commented Apr 9, 2024 •
edited by UlisesGascon
Loading

Action passing https://github.com/carpasse/content-disposition/actions/runs/8619198332 https://github.com/jshttp/content-disposition/actions/runs/8619220422/job/23629632771?pr=48

UlisesGascon
UlisesGascon approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UlisesGascon UlisesGascon merged commit 6fce3d0 into jshttp:master Apr 9, 2024
25 checks passed
@carpasse carpasse deleted the fix-ci-gh-action branch April 10, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carpasse @UlisesGascon