Skip to content

Commit

Permalink
Fixup sdist release. (pantsbuild#5067)
Browse files Browse the repository at this point in the history
Previously the publishing step assumed sdists had been generated but
there was no step actually doing this. Have `publish_packages` call
`build_packages` to ensure this.

Fixes pantsbuild#5027
  • Loading branch information
jsirois authored Nov 6, 2017
1 parent ec29e2e commit 8390373
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions build-support/bin/release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -549,6 +549,12 @@ function activate_twine() {
}

function publish_packages() {
# TODO(John Sirois): Remove sdist generation and twine upload when
# https://github.com/pantsbuild/pants/issues/4956 is resolved.
# NB: We need this step to generate sdists. It also generates wheels locally, but we nuke them
# and replace with pre-tested binary wheels we download from s3.
build_packages

rm -rf "${DEPLOY_WHEEL_DIR}"
mkdir -p "${DEPLOY_WHEEL_DIR}"

Expand Down

0 comments on commit 8390373

Please sign in to comment.