Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: pre-release points to incorrect latest stable #488

Closed
iuioiua opened this issue May 8, 2024 · 5 comments · Fixed by #490
Closed

bug: pre-release points to incorrect latest stable #488

iuioiua opened this issue May 8, 2024 · 5 comments · Fixed by #490
Assignees
Labels
bug Something isn't working

Comments

@iuioiua
Copy link
Contributor

iuioiua commented May 8, 2024

The version being pointed to is neither the latest version nor stable. Perhaps 0.x versions should instead point to 1.0.0-rc.x as the latest unstable versions.
jsr io_@std_bytes@1 0 0-rc 1

@marvinhagemeister
Copy link
Contributor

For reference, this is the link https://jsr.io/@std/bytes@1.0.0-rc.1

@iuioiua
Copy link
Contributor Author

iuioiua commented May 8, 2024

Whoops, sorry... 😆

@lucacasonato
Copy link
Member

This message is correct. We consider prereleases unstable, and releases without a prerelease tag as stable.

@lucacasonato
Copy link
Member

Ok, thinking about this some more: I think part of this makes sense, parts are not great:

  • 1.0.0-rc.1 is considered a pre-release, so we do not consider it latest for semver purposes. This makes sense, and is expected. https://jsr.io/@std/bytes showing 0.224.0 instead of 1.0.0-rc.1 is correct.
  • The link pointing to an older release is weird. I think we should do this:
    • If the prerelease is "semver before" the latest release, show the "Go to latest"
    • If the prerelease is "semver after" the latest stable release, show just "This is a prerelease." with no other info and no other message.

@lucacasonato
Copy link
Member

Changed my mind again about the links. Updated the copy here: #490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants