Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remember the users package manager preference #548

Merged
merged 2 commits into from
May 22, 2024

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented May 22, 2024

The usage box will now remember what package manager the user last selected for the next page load / session.

This data is stored on device, and thus does not sync between devices.

Closes #546

The usage box will now remember what package manager the user last selected for the next page load / session.

This data is stored on device, and thus does not sync between devices.
Copy link
Collaborator

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacasonato lucacasonato added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 8a50673 May 22, 2024
8 checks passed
@lucacasonato lucacasonato deleted the remember_package_manager_preference branch May 22, 2024 13:43
github-merge-queue bot pushed a commit that referenced this pull request May 24, 2024
This fixes a bug that occurred in #548.


If you select Bun in a package(e.g. https://jsr.io/@std/assert) and move
to another package(e.g. https://jsr.io/@std/archive) where Bun does not
work, the package manager will not display correctly.



![image](https://github.com/jsr-io/jsr/assets/114303361/ad3b555d-5d71-4750-9a9e-f07394e0a303)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persist "Use with" selection
3 participants