feat: Add keyboard shortcut to package search and symbol search #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-collinsworth
requested changes
Feb 29, 2024
bartlomieju
changed the title
|
@josh-collinsworth I also added keyboard shortcut for symbol search on package page (S). Please take another look. |
josh-collinsworth
approved these changes
Feb 29, 2024
josh-collinsworth
requested changes
Feb 29, 2024
| @@ -104,6 +104,20 @@ export function LocalSymbolSearch( | |||
| return () => document.removeEventListener("click", outsideClick); | |||
| }, []); | |||
|
|
|||
| useEffect(() => { | |||
| const keyboardHandler = (e: KeyboardEvent) => { | |||
| if (e.key === "S") { | |||
There was a problem hiding this comment.
Sorry, I didn't see this before but I don't think it's probably a good idea. There's lots of reasons a user might type S on a page. (Not least of which, in the package search in the header; if a user tries to type a capital S anywhere on the page, they'll be jumped to the search box.)
I think maybe we should just leave this one alone for now.
There was a problem hiding this comment.
Thanks, good catch. Changed the shortcut to Cmd + / and Ctrl + /. Let me know if that's better
josh-collinsworth
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package search shortcut: "Cmd + K" on Mac, "Ctrl + K" on Windows and Linux
Symbol search shortcut: "Cmd + /" on Mac, "Ctrl + /" on Windows and Linux.
Closes #30