Add x_tolerance_ratio param to extract_text and similar functions (now properly linted!)
#1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1041 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 1615 1620 +5
=========================================
+ Hits 1615 1620 +5
|
Tries removing the property-setting, which felt a bit too complex.
Feedback/suggestions on PR 1041
|
Thanks, and now merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #987 (partially)
Passing x_tolerance_ratio to extract_text() and any other function that relies on WordExtractor will use the ratio * text size to determine where words begin and end. Overrides the x_tolerance param.
There is room to build out y_tolerance_ratio too, if need be in the future!