Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-unknown-property: allow allowFullScreen on iframe #3455

Merged

Conversation

almeidx
Copy link
Contributor

@almeidx almeidx commented Oct 10, 2022

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #3455 (b42a0f3) into master (17858be) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3455   +/-   ##
=======================================
  Coverage   97.58%   97.58%           
=======================================
  Files         127      127           
  Lines        9068     9068           
  Branches     3308     3308           
=======================================
  Hits         8849     8849           
  Misses        219      219           
Impacted Files Coverage Δ
lib/rules/no-unknown-property.js 98.82% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb force-pushed the no-unknown-property/iframe-allowfullscreen branch from 1093a96 to b42a0f3 Compare October 10, 2022 21:46
@ljharb ljharb merged commit b42a0f3 into jsx-eslint:master Oct 10, 2022
@ljharb
Copy link
Member

ljharb commented Oct 10, 2022

I'll be backporting this into a patch release of v7.31.10 shortly, before later publishing a v7.31.11 (which will also include this fix).

ljharb pushed a commit that referenced this pull request Oct 10, 2022
@ljharb
Copy link
Member

ljharb commented Oct 10, 2022

Published.

@almeidx almeidx deleted the no-unknown-property/iframe-allowfullscreen branch October 11, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants