Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] prop-types: className missing in prop validation #3749

Merged
merged 1 commit into from
Jun 20, 2024
Merged

[Fix] prop-types: className missing in prop validation #3749

merged 1 commit into from
Jun 20, 2024

Conversation

akulsr0
Copy link
Contributor

@akulsr0 akulsr0 commented May 6, 2024 •
edited
Loading

Closes #3284

ljharb
ljharb reviewed May 6, 2024
View reviewed changes
lib/util/propTypes.js Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.60%. Comparing base (cef8123) to head (21ba4c5).

❗ Current head 21ba4c5 differs from pull request most recent head b747450

Please upload reports for the commit b747450 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3749      +/-   ##
==========================================
- Coverage   97.62%   97.60%   -0.03%     
==========================================
  Files         134      133       -1     
  Lines        9617     9473     -144     
  Branches     3488     3470      -18     
==========================================
- Hits         9389     9246     -143     
+ Misses        228      227       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb ljharb force-pushed the akul/prop-types-className-issue branch from 21ba4c5 to 9ac517f Compare June 1, 2024 05:33
@ljharb ljharb marked this pull request as draft June 1, 2024 05:34
@akulsr0 akulsr0 marked this pull request as ready for review June 18, 2024 12:53
@ljharb ljharb force-pushed the akul/prop-types-className-issue branch from 816a0d5 to 2a267d6 Compare June 20, 2024 20:49
@ljharb ljharb force-pushed the akul/prop-types-className-issue branch from 2a267d6 to b747450 Compare June 20, 2024 20:52
@ljharb ljharb merged commit b747450 into jsx-eslint:master Jun 20, 2024
328 checks passed
@gabrc52 gabrc52 mentioned this pull request Jul 15, 2024
Merged
@mindthecap mindthecap mentioned this pull request Jul 15, 2024
Merged
@elitenoire elitenoire mentioned this pull request Jul 18, 2024
Merged
This was referenced Aug 3, 2024
Open
Open
@patooworld patooworld mentioned this pull request Aug 3, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Aug 3, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Aug 4, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Aug 4, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Aug 4, 2024
Open
This was referenced Aug 4, 2024
Open
Open
Open
@X-oss-byte X-oss-byte mentioned this pull request Aug 4, 2024
Open
@zdr4k zdr4k mentioned this pull request Aug 4, 2024
Open
This was referenced Aug 4, 2024
Open
Open
Open
@richyhoopd richyhoopd mentioned this pull request Aug 5, 2024
Open
This was referenced Oct 3, 2024
Open
Open
Open
@richyhoopd richyhoopd mentioned this pull request Oct 3, 2024
Open
This was referenced Oct 3, 2024
Open
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 3, 2024
Open
This was referenced Oct 3, 2024
Open
Open
Open
@scatools-demo scatools-demo mentioned this pull request Oct 3, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Oct 4, 2024
Open
@DadonStyle DadonStyle mentioned this pull request Oct 4, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Oct 4, 2024
Open
@zdr4k zdr4k mentioned this pull request Oct 4, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 4, 2024
Open
Open
Open
@richyhoopd richyhoopd mentioned this pull request Oct 4, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 4, 2024
Open
@jetboard jetboard mentioned this pull request Oct 4, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Oct 4, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 4, 2024
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Oct 4, 2024
Open
@CASABECI CASABECI mentioned this pull request Oct 6, 2024
Open
@scatools-demo scatools-demo mentioned this pull request Oct 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
typescript
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript "'className' is missing in props validation" despite being defined
2 participants
@akulsr0 @ljharb