[Fix] sort-prop-types: Check for undefined before accessing node.typeAnnotation.typeAnnotation

[tylerlaprade]

Fixes the bug reported in this comment

[ljharb]

We'll need a regression test before this fix can land.

[ljharb]

@tylerlaprade can you share the code that errored in your linked comment?

[tylerlaprade]

@ljharb, in a file with a .tsx extension, the following repros:

function Foo() {
  return <></>;
}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.49%. Comparing base (cef8123) to head (99d6a36).
Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3779      +/-   ##
==========================================
- Coverage   97.62%   97.49%   -0.14%     
==========================================
  Files         134      134              
  Lines        9617     9634      +17     
  Branches     3488     3496       +8     
==========================================
+ Hits         9389     9393       +4     
- Misses        228      241      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tylerlaprade]

Thanks for adding the test case! It looks like some snapshots need to be updated, but when I npm test locally, I don't see any failures.

[ljharb]

we don't use snapshots :-) it's just that some of the test jobs don't support fragments. i switched it to a div instead.