support hasMany option for splice

jtarchie · Nov 29, 2012 · 0eaf016 · 0eaf016
1 parent 99e279b
commit 0eaf016
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/underscore.lua b/lib/underscore.lua
@@ -23,6 +23,8 @@ function _.splice(list, index, howMany, ...)
   local elements = {...}
   local removed = {}
 
+  howMany = howMany or #list - index + 1
+
   for i = 1, #elements, 1 do
     table.insert(list, i + index + howMany - 1, elements[i])
   end

diff --git a/spec/arrays_spec.lua b/spec/arrays_spec.lua
@@ -378,4 +378,11 @@ describe("#splice", function()
     assert.same(array, {"parrot", "blue", "grape", "mandarin", "surgeon"})
     assert.same(removed, {'angel', 'clown'})
   end)
+
+  it("removes all elements when no hasMany is ", function()
+    local array = {"angel", "clown", "mandarin", "surgeon"}
+    local removed = _.splice(array, 3)
+    assert.same(removed, {"mandarin", "surgeon"})
+    assert.same(array, {'angel', 'clown'})
+  end)
 end)