Skip to content

Commit

Permalink
[CMAKE] Fix cmake warning
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=140497

Reviewed by Gustavo Noronha Silva.

r173155 already tried to fix cmake warning though, the warning is still exist.
CMAKE_LINK_INTERFACE_LIBRARIES seems to cause this warning. Individual target is
already set for their libraries though, INTERFACE_LINK_LIBRARIES contains the list
of transitive link dependencies, and CMAKE_LINK_INTERFACE_LIBRARIES can override
the INTERFACE_LINK_LIBRARIES property when CMP0022 is not set. CMake warns this override.
To avoid it, EFL port doesn't set CMAKE_LINK_INTERFACE_LIBRARIES.

* CMakeLists.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@178682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
gyuyoung.kim@samsung.com committed Jan 20, 2015
1 parent 8cb90a3 commit 2bbb376
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 3 deletions.
3 changes: 0 additions & 3 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ if (NOT DEFINED ENABLE_TOOLS AND EXISTS ${TOOLS_DIR})
set(ENABLE_TOOLS ON)
endif ()

# Do not create transitive library dependencies by default
set(CMAKE_LINK_INTERFACE_LIBRARIES "")

include(WebKitMacros)
include(WebKitFS)
include(WebKitHelpers)
Expand Down
16 changes: 16 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
2015-01-19 Gyuyoung Kim <gyuyoung.kim@samsung.com>

[CMAKE] Fix cmake warning
https://bugs.webkit.org/show_bug.cgi?id=140497

Reviewed by Gustavo Noronha Silva.

r173155 already tried to fix cmake warning though, the warning is still exist.
CMAKE_LINK_INTERFACE_LIBRARIES seems to cause this warning. Individual target is
already set for their libraries though, INTERFACE_LINK_LIBRARIES contains the list
of transitive link dependencies, and CMAKE_LINK_INTERFACE_LIBRARIES can override
the INTERFACE_LINK_LIBRARIES property when CMP0022 is not set. CMake warns this override.
To avoid it, EFL port doesn't set CMAKE_LINK_INTERFACE_LIBRARIES.

* CMakeLists.txt:

2015-01-19 Michael Catanzaro <mcatanzaro@igalia.com>

[GTK] Generate the make dist manifest from a CMake template file
Expand Down

0 comments on commit 2bbb376

Please sign in to comment.