Optimized Model.refresh_from_db(fields=...) by using a set.

jugurtha114 · Mar 8, 2024 · 74f7fe3 · 74f7fe3
1 parent 0c690c6
commit 74f7fe3
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/django/db/models/base.py b/django/db/models/base.py
@@ -691,8 +691,8 @@ def refresh_from_db(self, using=None, fields=None, from_queryset=None):
             self._prefetched_objects_cache = {}
         else:
             prefetched_objects_cache = getattr(self, "_prefetched_objects_cache", ())
-            fields = list(fields)
-            for field in list(fields):
+            fields = set(fields)
+            for field in fields.copy():
                 if field in prefetched_objects_cache:
                     del prefetched_objects_cache[field]
                     fields.remove(field)
@@ -717,11 +717,11 @@ def refresh_from_db(self, using=None, fields=None, from_queryset=None):
         if fields is not None:
             db_instance_qs = db_instance_qs.only(*fields)
         elif deferred_fields:
-            fields = [
+            fields = {
                 f.attname
                 for f in self._meta.concrete_fields
                 if f.attname not in deferred_fields
-            ]
+            }
             db_instance_qs = db_instance_qs.only(*fields)
 
         db_instance = db_instance_qs.get()