Refs #35295 -- Added BaseDatabaseOperations.bulk_insert_sql().

Co-authored-by: Nick Pope <nick@nickpope.me.uk>
jugurtha114 · Mar 14, 2024 · 912f72a · 912f72a
1 parent 95ae378
commit 912f72a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 15 deletions.
diff --git a/django/db/backends/base/operations.py b/django/db/backends/base/operations.py
@@ -276,6 +276,11 @@ def limit_offset_sql(self, low_mark, high_mark):
             if sql
         )
 
+    def bulk_insert_sql(self, fields, placeholder_rows):
+        placeholder_rows_sql = (", ".join(row) for row in placeholder_rows)
+        values_sql = ", ".join([f"({sql})" for sql in placeholder_rows_sql])
+        return f"VALUES {values_sql}"
+
     def last_executed_query(self, cursor, sql, params):
         """
         Return a string of the query last executed by the given cursor, with

diff --git a/django/db/backends/mysql/operations.py b/django/db/backends/mysql/operations.py
@@ -290,11 +290,6 @@ def max_name_length(self):
     def pk_default_value(self):
         return "NULL"
 
-    def bulk_insert_sql(self, fields, placeholder_rows):
-        placeholder_rows_sql = (", ".join(row) for row in placeholder_rows)
-        values_sql = ", ".join("(%s)" % sql for sql in placeholder_rows_sql)
-        return "VALUES " + values_sql
-
     def combine_expression(self, connector, sub_expressions):
         if connector == "^":
             return "POW(%s)" % ",".join(sub_expressions)

diff --git a/django/db/backends/postgresql/operations.py b/django/db/backends/postgresql/operations.py
@@ -328,11 +328,6 @@ def return_insert_columns(self, fields):
         ]
         return "RETURNING %s" % ", ".join(columns), ()
 
-    def bulk_insert_sql(self, fields, placeholder_rows):
-        placeholder_rows_sql = (", ".join(row) for row in placeholder_rows)
-        values_sql = ", ".join("(%s)" % sql for sql in placeholder_rows_sql)
-        return "VALUES " + values_sql
-
     if is_psycopg3:
 
         def adapt_integerfield_value(self, value, internal_type):

diff --git a/django/db/backends/sqlite3/operations.py b/django/db/backends/sqlite3/operations.py
@@ -353,11 +353,6 @@ def convert_uuidfield_value(self, value, expression, connection):
     def convert_booleanfield_value(self, value, expression, connection):
         return bool(value) if value in (1, 0) else value
 
-    def bulk_insert_sql(self, fields, placeholder_rows):
-        placeholder_rows_sql = (", ".join(row) for row in placeholder_rows)
-        values_sql = ", ".join(f"({sql})" for sql in placeholder_rows_sql)
-        return f"VALUES {values_sql}"
-
     def combine_expression(self, connector, sub_expressions):
         # SQLite doesn't have a ^ operator, so use the user-defined POWER
         # function that's registered in connect().