Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent document completions are showing up in nested documents #969

Closed
krassowski opened this issue Aug 28, 2023 · 2 comments · Fixed by #975
Closed

Parent document completions are showing up in nested documents #969

krassowski opened this issue Aug 28, 2023 · 2 comments · Fixed by #975
Labels
bug Something isn't working
Milestone

Comments

@krassowski
Copy link
Member

Description

With the completion providers API we cannot suppress the completions from other kernel in transclusions, e.g. in magics like %%sql or %%R.

Reproduce

Screenshot from 2023-08-28 21-10-39

See that both r2table from R via LSP and range/repr/reversed from Python kernel are showing up.

Expected behavior

Only relevant completions are shown

Context

  • JupyterLab version: 4.0.5
  • 5.0.0-a1
@krassowski krassowski added the bug Something isn't working label Aug 28, 2023
@krassowski
Copy link
Member Author

We can solve this by overriding isApplicable() in kernel/context provider (because we are overriding them anyways).

@krassowski krassowski added this to the 5.0 milestone Aug 29, 2023
@krassowski
Copy link
Member Author

This is not pretty because isApplicable only gets context and not the request position. We can still get the editor position from editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant