Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues identified in 5.0.0b0, prepare 5.0.0b1 #975

Merged
merged 5 commits into from
Sep 2, 2023

Conversation

krassowski
Copy link
Member

References

Closes #969
Closes #974
Closes #973

Code changes

  • implements isApplicable for kernel completion provider override
  • switches to editor wrapper in diagnostics listing to enable scrolling to out-of-view cells
  • improves support for windowed notebook but it is still imperfect (diagnostics may be not rendered if scrolling fast and then coming back)

User-facing changes

Changes the colour of highlights to slightly darker and removes dotted outline. Feedback welcome.

Backwards-incompatible changes

IEditorDiagnostic now uses editorAccessor instead of editor.

@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Binder 👈 Launch a binder notebook on branch krassowski/jupyterlab-lsp/bugfixes

@bollwyvl
Copy link
Collaborator

bollwyvl commented Sep 2, 2023

I haven't yet gotten a working checkout up yet to even do a resolve, but perhaps this could this add || ^4.1.0.alpha0 to start looking at what's in main upstream? Seems likely 4.1.0 might be a more suitable target, anyway, if upstream changes will be needed.

@krassowski
Copy link
Member Author

Ha, I've just commented on #917 (comment). This is not because of semver (it is fine).

@krassowski
Copy link
Member Author

See 856e9f3.

@krassowski krassowski merged commit 86df891 into jupyter-lsp:main Sep 2, 2023
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants