Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix completions when type is not defined #1044

Merged

Conversation

krassowski
Copy link
Member

References

Fixes #1043

Code changes

  • add better typing to catch potential issues
  • resolve the issues highlighted by improved typing

User-facing changes

Context completions work again

Backwards-incompatible changes

None

@krassowski krassowski added the bug Something isn't working label Feb 4, 2024
Copy link

github-actions bot commented Feb 4, 2024

Binder 👈 Launch a binder notebook on branch krassowski/jupyterlab-lsp/fix-completion-when-type-empty

@krassowski krassowski merged commit ef333ce into jupyter-lsp:main Feb 4, 2024
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion failure on itemWidthHeuristic when item.type is missing
1 participant